[Toaster] Review required for non git layer UI

[Barros Pena, Belen]

On 30/08/2016 15:33, "toaster-bounces at yoctoproject.org on behalf of sujith
h" <toaster-bounces at yoctoproject.org on behalf of sujith.h at gmail.com>
wrote:

>Hi,
>
>
>I have made a few fixes for the build summary or configuration section
>which is available here:
>
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/ui-fi
>xes-for-non-git 
><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/ui-f
>ixes-for-non-git>

Mmm, I don't quite like what this is doing. The "Not applicable" messages
should only appear for layers that point to a local directory: they should
never appear for layers with source code pointing to a git repository.

If a layer points to a git repo and the layer branch and commit
information is not showing up, something funny is going on with that
layer. We should not hide it with the 'not applicable' message, which
should not become a fall back solution to data collection problems.

Cheers

Belén

>
>
>Let me know if there are any issues with this patch.
>
>
>
>Thanks,
>
>Sujith H
>
>-- 
>സുജിത് ഹരിദാസന്
>Bangalore
><Project>Contributor to KDE project
>
><Project>Contributor to Yocto project
>
>http://fci.wikia.com/wiki/Anti-DRM-Campaign
><Blog> http://sujithh.info
>
>C-x C-c
>
>
>
>
>
>
>
>
>
>