[Toaster] [review-request][PATCH 0/3] remove ssh build controller

Brian Avery avery.brian at gmail.com
Wed Feb 3 08:13:29 PST 2016


Hi,

I looked at this while I was in Atlanta. I had no problems with it but
I tend to agree with elliot that I'd prefer to not let it get in
michael's way for ic, so we should probably pend it til ic get's in.
-b

On Wed, Feb 3, 2016 at 6:25 AM, sujith h <sujith.h at gmail.com> wrote:
>
>
> On Wed, Jan 20, 2016 at 5:20 PM, Ed Bartosh <ed.bartosh at linux.intel.com>
> wrote:
>>
>> Hi,
>>
>> sshbecontroller code and tests are broken for months. Its
>> functionality(running
>> builds on remote machine) can be achieved by simply running manage.py
>> runbuilds
>> on remote machine. There is not need to keep it in the codebase and
>> confuse
>> users from my point of view.
>
>
> It did confuse me :)
>
>>
>>
>> This change would also make refactoring of buildcontroller code
>> [YOCTO #8806] easier.
>>
>> The following changes since commit
>> c113ef1e40b9a5007c6b6af53226389fea706094:
>>
>>   toaster: tests Remove symlinks from toasteruitest folder (2016-01-20
>> 12:07:44 +0200)
>>
>> are available in the git repository at:
>>
>>   git://git.yoctoproject.org/poky-contrib ed/toaster/remove-ssh-controller
>>
>> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/remove-ssh-controller
>>
>> Ed Bartosh (3):
>>   toaster: raise NotImplementedError
>>   toaster: don't use sshbecontroller
>>   toaster: remove sshbecontroller module
>>
>>  bitbake/lib/toaster/bldcontrol/bbcontroller.py     |  16 +-
>>  .../migrations/0002_auto_20160120_1250.py          |  19 +++
>>  bitbake/lib/toaster/bldcontrol/models.py           |  10 +-
>>  bitbake/lib/toaster/bldcontrol/sshbecontroller.py  | 169
>> ---------------------
>>  bitbake/lib/toaster/bldcontrol/tests.py            |  30 +---
>>  5 files changed, 32 insertions(+), 212 deletions(-)
>>  create mode 100644
>> bitbake/lib/toaster/bldcontrol/migrations/0002_auto_20160120_1250.py
>>  delete mode 100644 bitbake/lib/toaster/bldcontrol/sshbecontroller.py
>>
>> --
>> Regards,
>> Ed
>>
>> --
>> _______________________________________________
>> toaster mailing list
>> toaster at yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
> --
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
>
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>


More information about the toaster mailing list