[Toaster] [PATCH 1/1] toaster: remove custom images from Image Recipes

Barros Pena, Belen belen.barros.pena at intel.com
Mon Feb 22 06:10:58 PST 2016



On 22/02/2016 14:48, "Barros Pena, Belen" <belen.barros.pena at intel.com>
wrote:

>
>
>On 19/02/2016 23:32, "toaster-bounces at yoctoproject.org on behalf of Dave
>Lerner" <toaster-bounces at yoctoproject.org on behalf of
>dave.lerner at windriver.com> wrote:
>
>>Fix the view of Image Recipes under Configuration to only show image
>>recipes that are not customised, since custom images have their own
>>page
>>
>>Signed-off-by: Dave Lerner <dave.lerner at windriver.com>
>>---
>> bitbake/lib/toaster/toastergui/tables.py | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>>diff --git a/bitbake/lib/toaster/toastergui/tables.py
>>b/bitbake/lib/toaster/toastergui/tables.py
>>index 86d111d..50a18e7 100644
>>--- a/bitbake/lib/toaster/toastergui/tables.py
>>+++ b/bitbake/lib/toaster/toastergui/tables.py
>>@@ -549,7 +549,9 @@ class ImageRecipesTable(RecipesTable):
>>     def setup_queryset(self, *args, **kwargs):
>>         super(ImageRecipesTable, self).setup_queryset(*args, **kwargs)
>> 
>>-        self.queryset = self.queryset.filter(is_image=True)
>>+        custom_image_recipes = CustomImageRecipe.objects.all()
>>+        self.queryset = self.queryset.filter(
>>+                Q(is_image=True) & ~Q(pk__in=custom_image_recipes))
>>         self.queryset = self.queryset.order_by(self.default_orderby)
>
>This patch removes the custom images from the compatible image recipes
>list (as requested by issue 9111), but also from the new custom image
>page. 

Sorry, my mistake: the custom images do appear in the new custom image
page. Mondays ...

Belén

>I think it might be useful to be able to create custom images
>selecting a custom image as your base image (for example, I might want to
>create a minimal-belen-dev from my minimal-belen custom image).
>
>If this is something we'd like to keep, we would need to modify the patch
>to remove the custom images from the compatible image recipes list, but
>not from the new custom image page.
>
>Thanks!
>
>Belén
>
>> 
>> 
>>-- 
>>1.9.1
>>
>>-- 
>>_______________________________________________
>>toaster mailing list
>>toaster at yoctoproject.org
>>https://lists.yoctoproject.org/listinfo/toaster
>



More information about the toaster mailing list