[Toaster] [RFC][PATCH 00/10] Build cancel

[Smith, Elliot]

On 22 February 2016 at 11:30, Michael Wood <michael.g.wood at intel.com> wrote:

> This is the combination of Sujith's and my work on build cancel. It needs
> an extra bit manual testing due to the number of time and state
> possibilities that can happen when trying to cancel a build.
>

I've been doing a bit of testing, and have found that I see the loading
spinner far more often than on toaster-next. Also, in the log, I'm seeing
lots of "database is locked" errors, which is likely to be the reason for
the spinner.

Compared to toaster-next, where I rarely get database locking errors, I've
had Toaster become unusable 3 times in the past 30 minutes due to database
locking on this branch.

Are we polling the server more frequently and possibly causing the locking?
Or is there something going on when you cancel a build which is putting the
app into a state where locking can occur?

I've also noticed that if Toaster locks up and I restart it, the build
which was ongoing before the database locked starts up again. I'm not sure
if this happens on toaster-next anyway (and I just haven't noticed because
I rarely get database locking), or if something has changed so that build
requests can trigger a build again, even if they were interrupted and
Toaster has been restarted.

Elliot




>
>
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=michaelw/sujith/build-cancel
>
> Michael Wood (6):
>   toaster: Move xhr calls for starting and stopping builds
>   toaster: xhr Update the implementation of the build cancellation
>     request
>   toaster: libtoaster Update implementation of startABuild and
>     cancelABuild
>   toaster: bldcontrol models Add a cancelling state the BuildRequest
>   buildinfohelper: Add handler for cancelling a build
>   toaster: mrb_section template Add build cancel button
>
> Sujith H (4):
>   toaster: bldcontrol Add forceShutDown function to BitbakeController
>   toaster: update BuildEnvironmentController and BitbakeController
>   toaster: models Add cancelled state to build outcome
>   toaster: tables BuildsTable exclude cancelled builds
>
>  bitbake/lib/bb/ui/buildinfohelper.py               |  17 +++-
>  bitbake/lib/toaster/bldcontrol/bbcontroller.py     |  29 ++----
>  .../toaster/bldcontrol/localhostbecontroller.py    |   6 +-
>  .../migrations/0002_add_cancelling_state.py        |  19 ++++
>  bitbake/lib/toaster/bldcontrol/models.py           |  27 ++++-
>  .../orm/migrations/0007_add_cancelled_state.py     |  19 ++++
>  bitbake/lib/toaster/orm/models.py                  |   7 +-
>  bitbake/lib/toaster/toastergui/api.py              | 109
> +++++++++++++++++++++
>  .../toaster/toastergui/static/js/customrecipe.js   |   4 +-
>  .../lib/toaster/toastergui/static/js/layerBtn.js   |   3 +-
>  .../lib/toaster/toastergui/static/js/libtoaster.js |  41 +++++---
>  .../toaster/toastergui/static/js/projectpage.js    |   4 +-
>  .../toaster/toastergui/static/js/projecttopbar.js  |   6 +-
>  .../toaster/toastergui/static/js/recipedetails.js  |   4 +-
>  bitbake/lib/toaster/toastergui/tables.py           |  48 +--------
>  bitbake/lib/toaster/toastergui/templates/base.html |   1 +
>  .../toaster/toastergui/templates/mrb_section.html  | 102
> +++++++++++++------
>  bitbake/lib/toaster/toastergui/urls.py             |   5 +
>  18 files changed, 320 insertions(+), 131 deletions(-)
>  create mode 100644
> bitbake/lib/toaster/bldcontrol/migrations/0002_add_cancelling_state.py
>  create mode 100644
> bitbake/lib/toaster/orm/migrations/0007_add_cancelled_state.py
>  create mode 100644 bitbake/lib/toaster/toastergui/api.py
>
> --
> 2.5.0
>
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20160222/afc81bd2/attachment.html>