[Toaster] [PATCH] toaster: custom breadcrumb for the default project

[Smith, Elliot]

Hello Belen, quick comment below.

On 23 February 2016 at 16:55, Belen Barros Pena <
belen.barros.pena at linux.intel.com> wrote:

> From: Belen Barros Pena <belen.barros.pena at intel.com>
>
> The default "Command line builds" project does not have a Configuration
> page. It therefore needs a custom breadcrumb where the project name goes
> to the project builds page, instead of the project configuration page.
>
> Signed-off-by: Belen Barros Pena <belen.barros.pena at intel.com>
> ---
>  .../lib/toaster/toastergui/templates/basebuilddetailpage.html    | 9
> +++++++--
>  bitbake/lib/toaster/toastergui/templates/basebuildpage.html      | 9
> +++++++--
>  2 files changed, 14 insertions(+), 4 deletions(-)
>
> diff --git
> a/bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html
> b/bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html
> index e350c1a..7f35cdf 100644
> --- a/bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html
> +++ b/bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html
> @@ -6,8 +6,13 @@
>  <!-- Breadcrumbs -->
>      <div class="section">
>          <ul class="breadcrumb" id="breadcrumb">
> -            <li><a href="{% url 'project' build.project.id %}">{{
> build.project.name}}</a></li>
> -            <li><a href="{% url 'projectbuilds' build.project.id
> %}">Builds</a></li>
> +            <li><a href="
> +              {% if build.project.is_default %}
> +                {% url 'projectbuilds' build.project.id %}">{{
> build.project.name}}</a></li>
> +              {% else %}
> +                {% url 'project' build.project.id %}">{{
> build.project.name}}</a></li>
>

You can use the project_url helper (see project_url_tag.py) to give you the
correct URL for the main page for a project, depending on whether it's the
default project or not.

Add this at the top of the template:

{% load project_url_tag %}

Then replace your changes with:

<li><a href="{% project_url build.project %}">{{build.project.name
}}</a></li>

Elliot

+                <li><a href="{% url 'projectbuilds' build.project.id
> %}">Builds</a></li>
> +              {% endif %}
>              <li><a href="{%url 'builddashboard' build.pk%}">{{build.get_sorted_target_list.0.target}}
> {%if build.target_set.all.count >
> 1%}(+{{build.target_set.all.count|add:"-1"}}){%endif%} {{build.machine}}
> ({{build.completed_on|date:"d/m/y H:i"}})</a></li>
>              {% block localbreadcrumb %}{% endblock %}
>          </ul>
> diff --git a/bitbake/lib/toaster/toastergui/templates/basebuildpage.html
> b/bitbake/lib/toaster/toastergui/templates/basebuildpage.html
> index 3571869..5bbd533 100644
> --- a/bitbake/lib/toaster/toastergui/templates/basebuildpage.html
> +++ b/bitbake/lib/toaster/toastergui/templates/basebuildpage.html
> @@ -8,8 +8,13 @@
>  <!-- Breadcrumbs -->
>      <div class="section">
>          <ul class="breadcrumb" id="breadcrumb">
> -            <li><a href="{% url 'project' build.project.id %}">{{
> build.project.name}}</a></li>
> -            <li><a href="{% url 'projectbuilds' build.project.id
> %}">Builds</a></li>
> +            <li>
> +              {% if build.project.is_default %}
> +                <a href="{% url 'projectbuilds' build.project.id %}">{{
> build.project.name}}</a></li>
> +              {% else %}
> +                <a href="{% url 'project' build.project.id %}">{{
> build.project.name}}</a></li>
> +                <li><a href="{% url 'projectbuilds' build.project.id
> %}">Builds</a></li>
> +              {% endif %}
>              <li>
>              {% block parentbreadcrumb %}
>              <a href="{%url 'builddashboard' build.pk%}">
> --
> 2.5.4 (Apple Git-61)
>
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20160223/a52a7462/attachment-0001.html>