[Toaster] RFC: fixes for 8443 (better display for failed builds)

[Barros Pena, Belen]

On 26/02/2016 15:38, "toaster-bounces at yoctoproject.org on behalf of Smith,
Elliot" <toaster-bounces at yoctoproject.org on behalf of
elliot.smith at intel.com> wrote:

>I've got a branch where I've implemented a fix for
>https://bugzilla.yoctoproject.org/show_bug.cgi?id=8443
>
>
>
>The branch is on poky-contrib:
>elliot/toaster/failed_builds_display-8443-rebased-on-failed_builds-8440-v5

This looks good to me. The only thing from the UI side is that the build
time in the build dashboard should not be a link in these builds, since
the build time page is not shown in any navigation, and it will be empty.
The build time is displayed correctly (i.e. not linked) in the 'recent
builds' section. 

Thanks!

Belén

>
>
>
>To test, start some failing builds:
>
>
>1. Bad target, e.g. zzzz
>2. Bad MACHINE
>3. Bad DISTRO
>
>
>These builds should have a dashboard without the left-hand nav panel;
>builds which fail later should show the full dashboard.
>
>
>As a quick solution (while we consider whether to rework Build and
>BuildRequest and their lifecycles), I've added a property to Build which
>counts the number of variables it has associated with it. This is because
>we don't record the variables against
> a Build until the BuildStarted event occurs, so we can tell whether
>BuildStarted has been received by querying a Build's associated variables.
>
>
>As you can see from the branch name, this needs the patches for 8440 to
>work correctly (where I split Build object creation into two pieces,
>before and after BuildStarted). So I rebased it on
>elliot/submit/failed_builds-8440-v5.
>
>
>The elliot/submit/failed_builds-8440-v5 branch is awaiting review:
>https://lists.yoctoproject.org/pipermail/toaster/2016-February/003837.html
>
>
>
>Once elliot/submit/failed_builds-8440-v5 is in toaster-next, I'll rebase
>again and formally submit
>elliot/toaster/failed_builds_display-8443-rebased-on-failed_builds-8440-v5
>.
>
>
>Thanks.
>Elliot
>-- 
>Elliot Smith
>Software Engineer
>Intel Open Source Technology Centre
>
>
>