[Toaster] [PATCH] toaster-tests: maximize browser window when running UI tests

[Michael Wood]

Thanks - Added to toaster-next

Michael

On 28/04/16 14:57, Barros Pena, Belen wrote:
>
> On 28/04/2016 14:31, "Smith, Elliot" <elliot.smith at intel.com> wrote:
>
>> On 28 April 2016 at 14:23, Barros Pena, Belen
>> <belen.barros.pena at intel.com> wrote:
>>
>> On 26/04/2016 17:12, "toaster-bounces at yoctoproject.org on behalf of Elliot
>> Smith" <toaster-bounces at yoctoproject.org on behalf of
>> elliot.smith at intel.com> wrote:
>>
>>> In some pages of the UI, the UI tests failed because parts of
>>> the UI which should be visible were being reported as not
>>> visible by the Selenium PhantomJS driver.
>>>
>>> On investigation, it turns out that PhantomJS uses a very narrow
>>> default window. This meant that some parts of the UI were being
>>> clipped and were thus not "visible" to the driver, causing test
>>> failures (specifically, on the new custom image page).
>> Interesting: Bootstrap is responsive, so stuff should still be visible.
>> Although our implementation of the responsive layout is not very clean,
>> components (with the exception of tables in very narrow viewports) should
>> wrap or stack vertically.
>>
>> Do you happen to know what's the viewport size of the PhantomJS default
>> window? Figuring out what's going on might help with the work migrating to
>> Bootstrap 3.
>>
>>
>>
>>
>> About 194px. I've attached a screenshot.
> Excellent: so tables and modals are causing the trouble. This is good to
> know.
>
> Thanks!
>
> Belén
>
>>
>> Elliot
>>
>>
>>
>>
>> Thanks!
>>
>> Belén
>>
>>> Ensure that the window is maximized before running tests to
>>> prevent this happening.
>>>
>>> Signed-off-by: Elliot Smith <elliot.smith at intel.com>
>>> ---
>>> bitbake/lib/toaster/tests/browser/selenium_helpers.py | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/bitbake/lib/toaster/tests/browser/selenium_helpers.py
>>> b/bitbake/lib/toaster/tests/browser/selenium_helpers.py
>>> index 56dbe2b..54db2e8 100644
>>> --- a/bitbake/lib/toaster/tests/browser/selenium_helpers.py
>>> +++ b/bitbake/lib/toaster/tests/browser/selenium_helpers.py
>>> @@ -130,6 +130,7 @@ class SeleniumTestCase(StaticLiveServerTestCase):
>>>          # instantiate the Selenium webdriver once for all the test
>>> methods
>>>          # in this test case
>>>          cls.driver = create_selenium_driver()
>>> +        cls.driver.maximize_window()
>>>
>>>      @classmethod
>>>      def tearDownClass(cls):
>>> --
>>> 1.9.3
>>>
>>> ---------------------------------------------------------------------
>>> Intel Corporation (UK) Limited
>>> Registered No. 1134945 (England)
>>> Registered Office: Pipers Way, Swindon SN3 1RJ
>>> VAT No: 860 2173 47
>>>
>>> This e-mail and any attachments may contain confidential material for
>>> the sole use of the intended recipient(s). Any review or distribution
>>> by others is strictly prohibited. If you are not the intended
>>> recipient, please contact the sender and delete all copies.
>>>
>>
>>> --
>>> _______________________________________________
>>> toaster mailing list
>>> toaster at yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/toaster
>>
>>
>>
>>
>>
>>
>>
>> -- 
>> Elliot Smith
>> Software Engineer
>> Intel Open Source Technology Centre
>>
>>
>>
>>