[Toaster] [PATCH] toaster: fix typo in arguments for libtoaster.js function

Michael Wood michael.g.wood at intel.com
Tue Jun 21 07:57:18 PDT 2016


Thanks, Submitted up to bitbake-devel and applied to toaster-next
Also opened a bug to create some tests for the project dashboard.

On 20/06/16 13:00, Elliot Smith wrote:
> The function for flattening the targets of a previous build
> to a space-separated list references prev and next arguments
> which aren't in the function signature. This prevents the "Rebuild"
> buttons (in the most-recent build section) from working.
>
> Fix the typo so that the buttons work again.
>
> Signed-off-by: Elliot Smith <elliot.smith at intel.com>
> ---
>   bitbake/lib/toaster/toastergui/static/js/libtoaster.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
> index eafe70d..a1379e1 100644
> --- a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
> +++ b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
> @@ -94,7 +94,7 @@ var libtoaster = (function () {
>   
>       /* Flatten the array of targets into a space spearated list */
>       if (targets instanceof Array){
> -      targets = targets.reduce(function(prevV, nextV){
> +      targets = targets.reduce(function(prev, next){
>           return prev + ' ' + next;
>         });
>       }



More information about the toaster mailing list