[Toaster] Review for #9071 ( issue with non-ascii characters)

[Smith, Elliot]

The other irony is that the function being passed the project name doesn't
do anything with it anyway, so it can be removed altogether from the HTML
and JS.

Elliot

On 9 March 2016 at 14:38, Smith, Elliot <elliot.smith at intel.com> wrote:

> Ironically, the error is nothing to do with unicode, but because of the
> single quote in the project name.
>
> I will submit a patch for it shortly.
>
> Elliot
>
> On 9 March 2016 at 13:26, Barros Pena, Belen <belen.barros.pena at intel.com>
> wrote:
>
>>
>>
>> On 09/03/2016 12:32, "Smith, Elliot" <elliot.smith at intel.com> wrote:
>>
>> >Are you using Firefox or Chrome? I can't reproduce this in Chrome.
>>
>> Chrome, but I can also reproduce the problem in Firefox.
>>
>> >Could you please provide a full series of steps to reproduce the issue?
>>
>> Yes I can :)
>>
>> 1. Create a project and make sure to add some funny characters in the name
>> (I use "Belén's project")
>> 2. Build something (for example, zlib)
>> 3. Once the build is done, click the 'rebuild' button
>>
>> Nothing happens.
>>
>> The Chrome console shows
>>
>> VM8619:269 Uncaught SyntaxError: Unexpected token ILLEGAL
>>
>> It works fine if the project name does not include funny characters.
>>
>> Cheers
>>
>> Belén
>>
>> >
>> >
>> >Thanks.
>> >Elliot
>> >
>> >
>> >
>> >
>> >On 9 March 2016 at 12:26, Smith, Elliot
>> ><elliot.smith at intel.com> wrote:
>> >
>> >I'll see if I can write a patch for that.
>> >
>> >Elliot
>> >
>> >
>> >On 9 March 2016 at 12:24, Barros Pena, Belen
>> ><belen.barros.pena at intel.com> wrote:
>> >
>> >
>> >
>> >On 08/03/2016 18:09, "toaster-bounces at yoctoproject.org on behalf of
>> Smith,
>> >Elliot" <toaster-bounces at yoctoproject.org on behalf of
>> >elliot.smith at intel.com> wrote:
>> >
>> >>Thanks for the patch. Reviewed, sent upstream to bitbake-devel, added to
>> >>poky-contrib/toaster-next.
>> >
>> >I might be too late, but this patch seems to fix the build form, but
>> >clicking the 'rebuild' button still fails to start a build if you have
>> >non-ascii characters in the project name. After you click the 'rebuild'
>> >button, the js console shows
>> >
>> >Uncaught SyntaxError: Unexpected token ILLEGAL
>> >
>> >The button works fine in projects without funny characters.
>> >
>> >Cheers
>> >
>> >Belén
>> >
>> >>
>> >>
>> >>Elliot
>> >>
>> >>
>> >>On 8 March 2016 at 14:24, sujith h <sujith.h at gmail.com> wrote:
>> >>
>> >>Hi,
>> >>
>> >>
>> >>I have created couple of patches for review at:
>> >>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/text
>> >>-
>> >>encoding
>> >><
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/tex
>> >>t
>> >>-encoding>
>> >>
>> >>
>> >>This is for bug
>> >>https://bugzilla.yoctoproject.org/show_bug.cgi?id=9071
>> >><https://bugzilla.yoctoproject.org/show_bug.cgi?id=9071>
>> >>
>> >>I have verified by adding non-ascii characters in the project name. And
>> >>the build was successful.
>> >>
>> >>
>> >>Thans,
>> >>
>> >>Sujith H
>> >>
>> >>--
>> >>സുജിത് ഹരിദാസന്
>> >>Bangalore
>> >><Project>Contributor to KDE project
>> >>
>> >><Project>Contributor to Yocto project
>> >>
>> >>http://fci.wikia.com/wiki/Anti-DRM-Campaign
>> >><Blog> http://sujithh.info
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>--
>> >>_______________________________________________
>> >>toaster mailing list
>> >>toaster at yoctoproject.org
>> >>https://lists.yoctoproject.org/listinfo/toaster
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>--
>> >>Elliot Smith
>> >>Software Engineer
>> >>Intel Open Source Technology Centre
>> >>
>> >>
>> >>
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >--
>> >Elliot Smith
>> >Software Engineer
>> >Intel Open Source Technology Centre
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >--
>> >Elliot Smith
>> >Software Engineer
>> >Intel Open Source Technology Centre
>> >
>> >
>> >
>>
>>
>
>
> --
> Elliot Smith
> Software Engineer
> Intel Open Source Technology Centre
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20160309/dfdd485a/attachment.html>