[Toaster] [PATCH 1/2] toasterui: Remove the excessive exception logging

Smith, Elliot elliot.smith at intel.com
Thu Mar 17 04:49:43 PDT 2016


Upstreamed to bitbake-devel and added to toaster-next.

Thanks.
Elliot

On 10 March 2016 at 14:28, Michael Wood <michael.g.wood at intel.com> wrote:

> Remove the very verbose log dump from toasterui. This generates several
> megabytes of not that useful debug information and actually hinders
> finding the original exception.
>
> Signed-off-by: Michael Wood <michael.g.wood at intel.com>
> ---
>  bitbake/lib/bb/ui/toasterui.py | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/bitbake/lib/bb/ui/toasterui.py
> b/bitbake/lib/bb/ui/toasterui.py
> index ee40110..29aed2e 100644
> --- a/bitbake/lib/bb/ui/toasterui.py
> +++ b/bitbake/lib/bb/ui/toasterui.py
> @@ -447,13 +447,6 @@ def main(server, eventHandler, params):
>              exception_data = traceback.format_exc()
>              logger.error("%s\n%s" , e, exception_data)
>
> -            _, _, tb = sys.exc_info()
> -            if tb is not None:
> -                curr = tb
> -                while curr is not None:
> -                    logger.error("Error data dump %s\n%s\n" ,
> traceback.format_tb(curr,1), pformat(curr.tb_frame.f_locals))
> -                    curr = curr.tb_next
> -
>              # save them to database, if possible; if it fails, we already
> logged to console.
>              try:
>                  buildinfohelper.store_log_exception("%s\n%s" % (str(e),
> exception_data))
> --
> 2.1.4
>
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20160317/89fcadc4/attachment.html>


More information about the toaster mailing list