[Toaster] [PATCH 5/5] toaster: make error message more informative

Michael Wood michael.g.wood at intel.com
Thu Sep 29 10:07:46 PDT 2016


Thanks for these patches, they've been sent upstream and applied to 
toaster-next.

Michael

On 24/09/16 15:50, Ed Bartosh wrote:
> Error message
>   ERROR: Unprocessed MetadataEvent <bb.event.MetadataEvent object at 0x7f750e671a58>
> doesn't give a lot of information about the event. It just prints
> event object, which is always bb.event.MetadataEvent.
>
> Including event type into the error message should make it more
> informative:
>   ERROR: Unprocessed MetadataEvent TaskArtifacts
>
> Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
> ---
>   bitbake/lib/bb/ui/toasterui.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/bb/ui/toasterui.py b/bitbake/lib/bb/ui/toasterui.py
> index 2bc45b6..9808f6b 100644
> --- a/bitbake/lib/bb/ui/toasterui.py
> +++ b/bitbake/lib/bb/ui/toasterui.py
> @@ -438,7 +438,7 @@ def main(server, eventHandler, params):
>                   elif event.type == "OSErrorException":
>                       logger.error(event)
>                   else:
> -                    logger.error("Unprocessed MetadataEvent %s ", str(event))
> +                    logger.error("Unprocessed MetadataEvent %s", event.type)
>                   continue
>   
>               if isinstance(event, bb.cooker.CookerExit):




More information about the toaster mailing list