[yocto] [PATCH 02/10] meta/common-pc: use usb features

[Tom Zanussi]

On Fri, 2012-05-11 at 09:12 -0700, Darren Hart wrote:
> 
> On 05/10/2012 05:59 PM, tom.zanussi at intel.com wrote:
> > From: Tom Zanussi <tom.zanussi at intel.com>
> > 
> > Use the available ehci and uhci usb features and remove the associated
> > config settings from the top-level common-pc feature.
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi at intel.com>
> 
> For what this does:
> 
> Acked-by: Darren Hart <dvhart at linux.intel.com>
> 
> Further thoughts:
> 
> I wonder why common-pc does not include OHCI HCDs?
> 
> >  CONFIG_USB_STORAGE=y
> 
> This should really be pulled out as well and added to the standard and
> preempt-rt bsp-ktype.scc files.
> 

The CONFIG_USB_STORAGE setting here is standalone, and the common-pc*
don't have the other options contained in the usb-mass-storage feature,
so that's why this was left behind.  Perhaps they should also include
the usb-mass-storage feature as well, but that would be adding more than
cleanup at this point.

Anyway, note that the later patches do add the usb-mass-storage to the
standard and preempt-rt files for the other non-common-pc* BSPs in the
patchset. 

> 
> >  CONFIG_USB_HID=y
> >  CONFIG_USB_HIDDEV=y
> > diff --git a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> > index bab45e6..2338ea6 100644
> > --- a/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> > +++ b/meta/cfg/kernel-cache/bsp/common-pc/common-pc.scc
> > @@ -2,6 +2,8 @@ kconf hardware common-pc.cfg
> >  kconf hardware common-pc-gfx.cfg
> >  
> >  include cfg/boot-live.scc
> 
> This should be moved to the standard and preempt-rt bsp-ktype.scc files
> as well.
> 

The later patches do this for the boot-live feature.

Tom

> > +include features/usb/ehci-hcd.scc
> > +include features/usb/uhci-hcd.scc
> >  include features/intel-e1xxxx/intel-e100.scc
> >  include features/intel-e1xxxx/intel-e1xxxx.scc
> >  include features/latencytop/latencytop.scc
>