[yocto] IMAGE_FEATURES check broken

[Paul Eggleton]

On Tuesday 14 May 2013 04:45:02 Gary Thomas wrote:
> This commit breaks systems where IMAGE_FEATURES includes
> "package-management":
> 
> commit d63c8a1597c9bd0a838cb59ca461ac432b630a90
> Author: Paul Eggleton <paul.eggleton at linux.intel.com>
> Date:   Thu May 9 17:24:25 2013 +0100
> 
>      classes/image: show an error on invalid IMAGE_FEATURES
> 
> A quick look at that class shows that package-management is being left
> out of the "validitems".  This patch fixes it:
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 2b42e12..4f07708 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
>   # IMAGE_FEATURES may contain any available package group
>   IMAGE_FEATURES ?= ""
>   IMAGE_FEATURES[type] = "list"
> -IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
> +IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs
> package-management"
> 
>   # rootfs bootstrap install
>   ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES",
> "package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR
> 
> Am I missing something else, or was this just overlooked?

It was overlooked, I'm afraid - images that inherit core-image don't have this 
problem because the package-management PACKAGE_GROUP is defined and this gets 
picked up. Images that don't (which is perfectly acceptable) get the failure, 
and I missed testing this case.

There is a patch pending to fix this however:

http://patchwork.openembedded.org/patch/49795/

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre