[yocto] coding style: hardcoding package names instead of using PN/BPN/etc

Robert P. J. Day rpjday at crashcourse.ca
Sat Nov 2 02:14:10 PDT 2013


  i figure the answer is obvious but i'll ask it anyway -- is it
reasonable to encourage new developers to use the general packagename
variables such as PN and BPN rather than hardcoding packagenames in
their recipe files?

  typically, you see things like this in recipe files:

ALLOW_EMPTY_${PN} = "1"
ALLOW_EMPTY_${PN}-staticdev = "1"

and so on. but, occasionally, someone decides to (unnecessarily?)
hardcode the package name, as in:

gst-va-intel.bb:ALLOW_EMPTY_gst-va-intel = "1"
gst-va-intel.bb:ALLOW_EMPTY_gst-va-intel-general = "1"
gst-va-intel.bb:ALLOW_EMPTY_gst-va-intel-video = "1"
gst-va-intel.bb:ALLOW_EMPTY_gst-va-intel-vaapi = "1"

i'm *assuming* the above could have been written more concisely by
using ${PN}, correct? is there a coding style preference that users
should be *encouraged* to use? is there a general coding style guide
anywhere?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================



More information about the yocto mailing list