[yocto] [patchwork][PATCH v4] patchwork.models: Include first patch's name in series name

[Jose Lamego]

On 12/05/2016 02:30 AM, Patrick Ohly wrote:
> On Fri, 2016-12-02 at 14:29 -0600, Jose Lamego wrote:
>> Patch Series created without a cover letter are named using a
>> non-descriptive generic string.
>>
>> This change names the series using either the first 30 characters in
>> patch #1 plus the remaining patches number, or the patch name for
>> one-patch (1/1) series.
>>
>> [YOCTO #10625]
>>
>> Signed-off-by: Jose Lamego <jose.a.lamego at linux.intel.com>
>> ---
>>  patchwork/models.py | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
> 
> When you send different versions of your patches, can you include a
> revision history? Otherwise, it's hard to see what changes between the
> different iterations.
> 
> git notes can be used for that for single-commit changes. See "git
> format-patch --notes" and "git notes".

Got it, thanks for the tip.

> 
>> diff --git a/patchwork/models.py b/patchwork/models.py
>> index 3f531e6..1521641 100644
>> --- a/patchwork/models.py
>> +++ b/patchwork/models.py
>> @@ -1042,6 +1042,19 @@ def _series_supersede_previous_patches(series):
>>  def _on_revision_complete(sender, revision, **kwargs):
>>      series = revision.series
>>
>> +    # Now we know how many patches are in the revision,
>> +    # so we can update the name for series without a cover letter
>> +    if series.name == SERIES_DEFAULT_NAME:
>> +        name = series.latest_revision().ordered_patches()[0].name
>> +        n = re.compile(r'(\[\d+\/\d+\]\s?)')
>> +        name = n.sub('', name)
>> +        c = len(series.latest_revision().ordered_patches())
>> +        # For one-patch series (1/1) without cover letter
>> +        if c == 1:
>> +            series.name = name
>> +        elif c > 1:
>> +            series.name = "\"%s...\" and %s more" % (name[:30], c-1)
>> +
>>      # update series.last_revision
>>      series.last_revision = series.latest_revision()
>>      series.save()
> 
> Looks reasonable to me, but I don't really know the code. Were you
> testing this and noticed cases with c == 0, i.e. cases where the last
> series,name change didn't make sense?
> 
Correct. There are cases where only a cover letter is sent (for example,
consolidated pull requests) so the patches number is 0.


-- 
Jose Lamego | OTC Embedded Platforms & Tools | GDC

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: OpenPGP digital signature
URL: <http://lists.yoctoproject.org/pipermail/yocto/attachments/20161205/b0c4d1ea/attachment.pgp>