[yocto] [PATCH] runtime: add BSP test case for usb storage

[Hussin, Mohamad Noor Alim]

HI Paul,

This patch is my supersede of earlier "manualbsp" which I split into 2 parts called usb test and microsd test.
I would use MACHINE_FEATURES = "usbhost" instead of introducing new variable as it would eliminate problem in case someone try to execute the usb test case without enable the "HARDWARE_TEST = 1" or download the image form public autobuilder.

> Otherwise I agree with Mike's reply, we should avoid writing to the storage device as part of the test.

It is mean that just do test like mount and unmount only? To read something in storage device we need to write at first place? 


Regards,
Alim Hussin

-----Original Message-----
From: Paul Eggleton [mailto:paul.eggleton at linux.intel.com] 
Sent: Monday, September 24, 2018 4:50 AM
To: Hussin, Mohamad Noor Alim <mohamad.noor.alim.hussin at intel.com>
Cc: yocto at yoctoproject.org
Subject: Re: [yocto] [PATCH] runtime: add BSP test case for usb storage

Hi Alim,

On Monday, 20 August 2018 3:22:09 AM NZST mohamad.noor.alim.hussin at intel.com wrote:
> From: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin at intel.com>
> 
> Contain test cases to test mount/unmount the usb stick on target 
> platform such as minnowboard and beaglebone. The test assume that the 
> usb storage device such as usb thumb drive was plugged into the target 
> device otherwise the test for would failed. It also test to read and 
> write from usb thumb drive. Usb test cases start with mount the usb 
> thumb drive then write and read from it. Lastly, it will unmount it. 
> If the usb thumb drive unable to mount due to corrupt of partition or 
> not exists, then the mount test will failed and the following test 
> would skip.

Does this supersede part of your earlier "manualbsp" patch? It's not made clear here or in the cover letter but it looks like it might.

The helper script patch needs to come before this patch rather than after it, since this patch won't work without it.
 
> This test need to enable flag 'HARDWARE_TEST = "1"' on conf/local.conf 
> file in order to run on target device. This test should be skip on qemu.

Can we use "usbhost" being in MACHINE_FEATURES and MACHINE not starting with "qemu" to enable this instead of adding another variable? (Assuming that sounds reasonable to everyone else)

Otherwise I agree with Mike's reply, we should avoid writing to the storage device as part of the test.

Also, as this is patching OE-Core, the patch needs to be sent to the openembedded-core at lists.openembedded.org mailing list, if you could please use that for the next revision that would be great.

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre