[linux-yocto] [PATCH 05/10] cfg/x86_base: Create new base config for x86 Architectures

[Darren Hart]

On 7/1/15 9:57 AM, Saul Wold wrote:
> Place the core x86 architecture kernel config items into a new
> base config that the other x86 related architectures will use
> 
> Signed-off-by: Saul Wold <sgw at linux.intel.com>
> ---
>  meta/cfg/kernel-cache/cfg/x86_base.cfg | 9 +++++++++
>  meta/cfg/kernel-cache/cfg/x86_base.scc | 4 ++++
>  2 files changed, 13 insertions(+)
>  create mode 100644 meta/cfg/kernel-cache/cfg/x86_base.cfg
>  create mode 100644 meta/cfg/kernel-cache/cfg/x86_base.scc
> 
> diff --git a/meta/cfg/kernel-cache/cfg/x86_base.cfg b/meta/cfg/kernel-cache/cfg/x86_base.cfg
> new file mode 100644
> index 0000000..39263ef
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/cfg/x86_base.cfg
> @@ -0,0 +1,9 @@
> +CONFIG_X86=y
> +CONFIG_X86_MSR=y
> +CONFIG_X86_CPUID=y
> +CONFIG_MTRR=y
> +CONFIG_PCI_MSI=y

PCI_MSI seems a strange option for this list. It depends on PCI=y which
isn't specified. It is automatically selected for one case (AMD
specific). Curious how this ended up here.

> +
> +CONFIG_X86_CHECK_BIOS_CORRUPTION=y
> +CONFIG_X86_BOOTPARAM_MEMORY_CORRUPTION_CHECK=y
> +# CONFIG_MTRR_SANITIZER is not set

Since this is expressly disabling something that is recommended to leave
on, and which has a enable/disable default, and can be controlled via
the command line - we need a specific reason for disabling
MTRR_SANITIZER. Do we have a compelling case for disabling this on ALL
x86 systems?

> diff --git a/meta/cfg/kernel-cache/cfg/x86_base.scc b/meta/cfg/kernel-cache/cfg/x86_base.scc
> new file mode 100644
> index 0000000..a75808d
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/cfg/x86_base.scc
> @@ -0,0 +1,4 @@
> +include efi.scc
> +include timer/hpet.scc
> +include timer/no_hz.scc
> +kconf hardware x86_base.cfg
> 

-- 
Darren Hart
Intel Open Source Technology Center