[meta-ti] [PATCH v2] dspdce-fw: Updated dspdce firmware for latest IPC version

[Denys Dmytriyenko]

Karthik,

I'm at lost here. You did address my previous comment of not leaving 2 
versions, just updating from .02 to .04, but I don't understand why do you 
need an .inc file for, if there's only one version left?

I traced it a bit back and there was a recommendation from Franklin about 
creating .inc file for a different recipe for ipumm-fw, but in that case it is 
warranted due to the fact that you pull 2 different sources for 2 platforms. 
So, in that case it might be better having 2 separate recipes for different 
machines with common parts in the .inc file, but see for yourself if that 
produces cleaner and simpler results. It's not alwats clear cut and you may 
need to experiment to choose the right option...

Either way, dspdce-fw doesn't seem to need an .inc file.

-- 
Denys


On Wed, Oct 01, 2014 at 11:14:51AM +0530, Karthik Ramanan wrote:
> Also refactored the dspdce-fw recipes to have inc file
> for common parts
> 
> Signed-off-by: Karthik Ramanan <a0393906 at ti.com>
> ---
>  recipes-bsp/dspdce-fw/dspdce-fw.inc           |   18 ++++++++++++++++++
>  recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb |   24 ------------------------
>  recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb |   11 +++++++++++
>  3 files changed, 29 insertions(+), 24 deletions(-)
>  create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw.inc
>  delete mode 100644 recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
>  create mode 100644 recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
> 
> diff --git a/recipes-bsp/dspdce-fw/dspdce-fw.inc b/recipes-bsp/dspdce-fw/dspdce-fw.inc
> new file mode 100644
> index 0000000..9676888
> --- /dev/null
> +++ b/recipes-bsp/dspdce-fw/dspdce-fw.inc
> @@ -0,0 +1,18 @@
> +DESCRIPTION = "Firmware for DSP for an example application called copycodectest"
> +LICENSE = "TI-TSPA"
> +
> +COMPATIBLE_MACHINE = "dra7xx-evm"
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +S = "${WORKDIR}/dspdce-${MACHINE}-${PV}"
> +
> +TARGET = "dra7-dsp1-fw.xe66"
> +
> +do_install() {
> +        mkdir -p ${D}${base_libdir}/firmware
> +        cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET}
> +}
> +
> +FILES_${PN} += "${base_libdir}/firmware/${TARGET}"
> +
> +INSANE_SKIP_${PN} = "arch"
> diff --git a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
> deleted file mode 100644
> index 69e9814..0000000
> --- a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.02.bb
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -DESCRIPTION = "Firmware for DSP "
> -LICENSE = "TI-TSPA"
> -LIC_FILES_CHKSUM = "file://DSPDCE-${PV}-Manifest.doc;md5=587a7b9fdd99f98fbe99af4a4ba3362a"
> -
> -COMPATIBLE_MACHINE = "dra7xx-evm"
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> -
> -SRC_URI = "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/dspdce/1_00_00_02/exports/dspdce-${MACHINE}-1.00.00.02.tar.gz;protocol=http"
> -
> -S = "${WORKDIR}/dspdce-${MACHINE}-${PV}"
> -
> -SRC_URI[md5sum] = "df19baf16f828b5d32b4eed50f0364f5"
> -SRC_URI[sha256sum] = "0c0f34674110d1ef0300b61b572a326daffb95a31cc9d45888b2e50a83c6f555"
> -
> -TARGET = "dra7-dsp1-fw.xe66"
> -
> -do_install() {
> -        mkdir -p ${D}${base_libdir}/firmware
> -        cp ${S}/firmware/${TARGET} ${D}${base_libdir}/firmware/${TARGET}
> -}
> -
> -FILES_${PN} += "${base_libdir}/firmware/${TARGET}"
> -
> -INSANE_SKIP_${PN} = "arch"
> diff --git a/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
> new file mode 100644
> index 0000000..db01f31
> --- /dev/null
> +++ b/recipes-bsp/dspdce-fw/dspdce-fw_1.00.00.04.bb
> @@ -0,0 +1,11 @@
> +require dspdce-fw.inc
> +
> +LIC_FILES_CHKSUM = "file://DSPDCE-${PV}-Manifest.doc;md5=b8feda5a3ed8197d05993c0d0ff5590e"
> +
> +PR = "r0"
> +
> +SRC_URI = " http://downloads.ti.com/dsps/dsps_public_sw/glsdk/dspdce/1_00_00_04/exports/dspdce-${MACHINE}-1.00.00.04.tar.gz;protocol=ftp"
> +
> +SRC_URI[md5sum] = "72722b12e90c26a85f7f1b56d749cad0"
> +SRC_URI[sha256sum] = "64057db41dbee5a992db88129a9154f27c67cfbba8efdc0f09b7de38df4d58eb"
> +
> -- 
> 1.7.9.5
> 
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti