[meta-xilinx] tools: app.tcl exits 0 regardless of build failure

[Jean-Francois Dagenais]

Hi guys,

Take a look at this:
https://github.com/Xilinx/meta-xilinx-tools/blob/master/scripts/app.tcl#L131

There's an "exit 0" regardless of the build success or failure! WOW.

I stubbled on this by intentionally putting an error in the workdir of
pmu-firmware's build dir. The log.do_compile does show the error and make
reports it, yet my yocto build succeeds!

Holy moly.

I am by no stretch a tcl programmer so can anyone either fix this or suggest a
code snippet? I would be glad to review and test.