[meta-xilinx] tools: app.tcl exits 0 regardless of build failure

[Manjukumar Harthikote Matha]

> -----Original Message-----
> From: Jean-Francois Dagenais [mailto:jeff.dagenais at gmail.com]
> Sent: Friday, June 02, 2017 12:22 PM
> To: Manjukumar Harthikote Matha <MANJUKUM at xilinx.com>
> Cc: meta-xilinx at yoctoproject.org
> Subject: tools: app.tcl exits 0 regardless of build failure
>
> Hi guys,
>
> Take a look at this:
> https://github.com/Xilinx/meta-xilinx-tools/blob/master/scripts/app.tcl#L131
>
> There's an "exit 0" regardless of the build success or failure! WOW.
>
xsct does not handle return code properly, there is no easy way to detect the failure. The fix for xsct might be in 2017.3 release.

> I stubbled on this by intentionally putting an error in the workdir of pmu-firmware's
> build dir. The log.do_compile does show the error and make reports it, yet my yocto
> build succeeds!
>
Yes we are aware of this issue, this will happen only if you have built the firmware successfully before. If it is a clean project it would fail during do_deploy mechanism.

> Holy moly.
>
> I am by no stretch a tcl programmer so can anyone either fix this or suggest a code
> snippet? I would be glad to review and test.

I will send out a patch which you could test out, basically it checks for elf was generated or not after clean build

Thanks
Manju


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.