[poky] [PATCH 0/1] single patch for new adt-installer feature

[Saul Wold]

On 01/03/2011 11:42 PM, Jessica Zhang wrote:
> This patch capture the adt-installer feature which includes a recipe file for generating adt-installer tar ball and all the script files and config files for adt-installer.
>
> Create this single patch to avoid the initial adt-install pull request messy situation for review.
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>    Branch: jzhang/installer-feature
>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jzhang/installer-feature
>
> Thanks,
>      Jessica Zhang<jessica.zhang at intel.com>
> ---
>
>
> Liping Ke (1):
>    adt-intaller feature implementation, including the bitbake recipe
>      file for creating the intaller tar file under /tmp/deploy/sdk, and
>      the adt-installer script files and config files
>
>   .../installer/adt-installer/adt_installer          |  363 ++++++++++++++++++++
>   .../installer/adt-installer/adt_installer.conf     |   29 ++
>   .../adt-installer/opkg/conf/opkg-sdk-i586.conf     |    7 +
>   .../adt-installer/opkg/conf/opkg-sdk-x86_64.conf   |    7 +
>   .../adt-installer/scripts/adt_installer_internal   |  207 +++++++++++
>   .../installer/adt-installer/scripts/data_define    |   35 ++
>   .../installer/adt-installer/scripts/extract_rootfs |   63 ++++
>   .../installer/adt-installer/scripts/util           |   99 ++++++
>   .../installer/adt-installer_1.0.bb                 |   61 ++++
Liping,

I notice that you have GPLv2 Headers in the scripts, but the .bb file 
refers to a MIT and the Poky main license, you should probably change 
these scripts to point use MIT Headers and copyright should be 2010-2011.

You should not be exposing internal intel host information in the .conf 
files, maybe you can use the autobuilder repos instead of an internal on 
since outside people will use this code also.

I am not sure I like the idea of /opt/poky being hardcoded, will this be 
addressed in the future?  I think that /opt/poky is still hard-coded in 
some of the tools, but I hope this will be changing in the future, so 
more of a heads up.

Sau!


>   9 files changed, 871 insertions(+), 0 deletions(-)
>   create mode 100755 meta/recipes-devtools/installer/adt-installer/adt_installer
>   create mode 100644 meta/recipes-devtools/installer/adt-installer/adt_installer.conf
>   create mode 100644 meta/recipes-devtools/installer/adt-installer/opkg/conf/opkg-sdk-i586.conf
>   create mode 100644 meta/recipes-devtools/installer/adt-installer/opkg/conf/opkg-sdk-x86_64.conf
>   create mode 100755 meta/recipes-devtools/installer/adt-installer/scripts/adt_installer_internal
>   create mode 100644 meta/recipes-devtools/installer/adt-installer/scripts/data_define
>   create mode 100755 meta/recipes-devtools/installer/adt-installer/scripts/extract_rootfs
>   create mode 100644 meta/recipes-devtools/installer/adt-installer/scripts/util
>   create mode 100644 meta/recipes-devtools/installer/adt-installer_1.0.bb
>
> _______________________________________________
> poky mailing list
> poky at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>