[poky] [PATCH 0/1] single patch for new adt-installer feature

[Ke, Liping]

Hi, Saul

Thanks for your review!


> Liping,
> 
> I notice that you have GPLv2 Headers in the scripts, but the .bb file
> refers to a MIT and the Poky main license, you should probably change
> these scripts to point use MIT Headers and copyright should be 2010-
> 2011.
> 
I will correct the license information when resend pull request.

> You should not be exposing internal intel host information in the .conf
> files, maybe you can use the autobuilder repos instead of an internal
> on
> since outside people will use this code also.
> 
Yes, this is only for internal testing since the infrastructure for installer
(should be in autobuilder for external access?) is not ready. The correct
address will given after the repo is setup.

> I am not sure I like the idea of /opt/poky being hardcoded, will this
> be
> addressed in the future?  I think that /opt/poky is still hard-coded in
> some of the tools, but I hope this will be changing in the future, so
> more of a heads up.

Yes, if the /opt/poky problem is fixed in the future, surely we'll update it.
But I guess it will not be ready in 1.0 release. So I will keep an eye on this.
Once modified, I will change it accordingly.

So, I will resend the patch after our external repo is setup.

Thanks a lot for your help!
criping
> 
> Sau!