[Toaster] Some Toaster implementation questions...

[Damian, Alexandru]

Hi,

I'm gonna try to answer questions below. CCing the list for reference to
others.

Hope this helps :).
Alex


On Tue, Jan 7, 2014 at 8:27 AM, Reyna, David <david.reyna at windriver.com>wrote:

> Also, how does "orderby" get defined in the GET request? My greps are not
> hitting anything, so I must be looking in the wrong places.
>
> [Alex] In toastergui/views.py, there is implementation for the GET
parameter "orderby". There is yet no example implementation in the HTML
templates, I'm working on that today.


> - David
>
> > -----Original Message-----
> > From: Reyna, David
> > Sent: Monday, January 06, 2014 11:58 PM
> > To: 'Damian, Alexandru'; 'Paul Eggleton'; belen.barros.pena at intel.com
> > Cc: Lerner, Dave; 'Bansal, Atul'; 'Zhang, Jessica'
> > Subject: Some Toaster implementation questions...
> >
> > Hi Alex and Belen,
> >
> > A few questions.
> >
> > 1) It appears that you have completed 4318 (table of all packages).
> > Should we mark this case as done? The "Edit Columns" enhancement of
> > course comes later with 4324.
> >
>
[Alex] In my view, we should mark the table "Done" when the correct default
columns are being displayed.
In practice, the correct default columns depends on the "Edit column"
functionality since the columns need to be defined in the context of the
page (views.py, see builds). So these bugs need to be marked Done at the
same time.


> > I do observe that there is the extraneous string "(files)" appended to
> > each package name, at least in the pull that I have. Should Dave fix
> > that as part of his work for 4328?
>

[Alex] Yes, please. Probably a leftover from "Simple UI", where this
would've been a link to the list of files in that package.


> >
> > 2) It appears that 4294 (table of recipes) is also mostly done. I need
> > to add the missing recipe detail links, which I can do together with my
> > 4299.
>

[Alex] Please see my answer above, for 4318. These tables are carry-overs
from the "Simple UI", and they don't necessarily match the design for the
normal UI !   The code in both the views.py and in the templates needs
updating to match the example for "builds" table.

>
> > 3) If I understand my 4299 correctly, I am listing all of the tasks
> > that match the recipe ID, sorted by the "order" value, and the recipe
> > informational sidebar comes from the recipe record via the ForeignKey
> > "recipe".
> >
> > This is perhaps a dumb question. In "class Task(models.Model)" I see
> > ...
> >
> >     search_allowed_fields = [ "recipe__name", "task_name" ]
> >
> > ... but the member name is "recipe". Is this misspelled, or is
> > "recipe__name" some weird python syntax?
>

[Alex] This is Django queryset syntax. This means  "object recipe, field
name". The SQL joins needed at database layer are automatically handled. I
know it's not intuitive, some reference is here:
https://docs.djangoproject.com/en/dev/ref/models/querysets/.


> >
> >
> > 4) A very minor point, I observe that the package views do not have the
> > name symmetry that you have set up for recipes and tasks. Can I make
> > the following suggestions:
> >
> > NOW:
> >   url(r'^build/(?P<build_id>\d+)/packages/$', 'bpackage',
> > name='packages'),
> >   url(r'^build/(?P<build_id>\d+)/package/(?P<package_id>\d+)$',
> > 'bfile', name='package'),
> >
> > PROPOSED?:
> >   url(r'^build/(?P<build_id>\d+)/packages/$', 'packages',
> > name='packages'),
> >   url(r'^build/(?P<build_id>\d+)/package/(?P<package_id>\d+)$',
> > package', name='package'),
>

[Alex] Good spotting ! This is a left-over from the days where we had two
packages, from building and installing steps. Now we have a sane single
package, so we indeed need to update this.


> >
> > - David
> >
> > > -----Original Message-----
> > > From: Reyna, David
> > > Sent: Monday, January 06, 2014 8:41 PM
> > > To: 'Damian, Alexandru'; Paul Eggleton; belen.barros.pena at intel.com
> > > Cc: Lerner, Dave; Bansal, Atul; Zhang, Jessica
> > > Subject: Toaster meeting (for January 8th)
> > >
> > > Hi all,
> > >
> > > FYI: Dave and I have grabbed the following cases, and I have updated
> > > bugzilla accordingly:
> > >   DR: 4299 recipes: View detailed information about a recipe
> > >   DL: 4328 packages: View detailed information about a package
> > >
> > > These first cases will probably be the hardest for us as we get the
> > > process down, and after that we should be able to go much faster. I
> > > expect that we will have a lot of questions for the meeting. We will
> > > try to send emails beforehand.
> > >
> > > I will set up the normal WebEx session for this Wednesday's meeting.
> > >
> > > - David
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140107/3e1f4eb5/attachment.html>