[Toaster] New push to master

[Damian, Alexandru]

Hi all,

Paul, thank you for the timely review :). It certainly helped a lot, and I
made the requested changes, and cleaned up other pages.

I also added a small number of other changes:
- the new interface is referred to as "Toaster GUI" throughout commit
messages, to keep consistent with the "toastergui" name of the
application/directory
- orderby functionality works if you click column headers in Build
Dashboard page and Configuration Variables page.
- The Configuration Variables page is now implemented reusing the same
mechanism as Build Dashboard table. The table headers and filter code are
generated using context metadata.

Paul, can you please re-review contrib/toaster/master and see if it's fit
for upstreaming ?

All developers, please rebase your changes on top of this latest version.
For code submissions, please post your poky-contrib branches to this
mailing list.

Cheers,
Alex



On Mon, Jan 6, 2014 at 6:13 PM, Paul Eggleton <paul.eggleton at linux.intel.com
> wrote:

> Hi Alex,
>
> On Monday 06 January 2014 15:02:46 Damian, Alexandru wrote:
> > I've pushed to master a new version with some reworked bits intended to
> > make it easier to develop table views without copying a lot of code.
> >
> > This version is also targeted at integration in origin/master, Paul, can
> > you please review it ?
>
> Just ran this - the functionality is great, good job. I'd like to see the
> grid
> columns being defined more in the database rather than in templates/code,
> but I
> guess we can add that optimisation later.
>
> There are some minor issues with the code itself however:
>
> > bitbake: toaster: clone Simple UI as base for Advanced UI
>
> * Don't add bootstrap 3.0 only to remove it in the next commit
>
> * This does more than just a clone and rename of the simple UI; there is a
> significant amount of code being added as well. I think this commit should
> stick to the copy/rename.
>
> * I'm not too thrilled with the s-prefixed template naming. Wouldn't it be
> better to just put these in a separate directory? Failing that, the prefix
> should be something a little more obvious e.g. "simple_"
>
> > bitbake: toaster: advanced UI, implement searching and filtering
>
> This commit does a bunch of re-indenting mixed in with material changes;
> this
> makes it hard to see what has actually changed.
>
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
>



-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140107/152f8521/attachment.html>