[Toaster] git push to poky-contrib/ravi

[Reyna, David]

Hi Ravi,

Here is my first pass review. 

1) I observe for your "...5ee1" commit there is no "Signed-off-by". Your other two commits do have that field.

  $ git log
  ...
  commit 2848c7e9cdb37890c5f602dc5a8cebc5fad95ee1
  Author: Ravi Chintakunta <ravi.chintakunta at timesys.com>
  Date:   Thu Jan 9 22:08:09 2014 -0500

    Django settings: Removed duplicate toastergui entry in INSTALLED_APPS

  [[ no "Signed-off-by" ]]
  ...

2) It does not appear that you have the row context coloring based on the "outcome" value. I actually have that working in my new "recipe details" page (via my "outcome_highlight" helper method). We could share this implantation.

3) It appears that "{% if not objects %}" is the same as "{% ifequal 0 objects.count %}". If so, I can simplify my code accordingly.

4) I observe that you have not implemented the href for the log file, presumably waiting for resolution of the questions you raised. 

Question for Belen. The sample All Tasks page from "yocto.com/toaster" has HREF links on all items in the table, but the design document has no reference as far as I can see to HREF usage.

5) Another question for Belen. The design document says that there are 3 values for "Cache Attempt" (presumably mapping to "sstate_result", but SSTATE_RESULT has 4 values, not three. And none of them map to an empty display string, in contrast to the screen shot in the design document.

- David

 

> -----Original Message-----
> From: Ravi Chintakunta [mailto:ravi.chintakunta at timesys.com]
> Sent: Friday, January 10, 2014 9:11 AM
> To: Reyna, David; Lerner, Dave; 'Damian, Alexandru'; 'Barros Pena,
> Belen'; 'Zhang, Jessica'; Bansal, Atul
> Cc: 'toaster at yoctoproject.org'
> Subject: git push to poky-contrib/ravi
> 
> I got push access from Michael and pushed a small commit to ravi/all-
> tasks-feature branch.
> 
> Just a few notes to help others with the first push.
> 
> 1. Changing the branch name:
> ============================
> It is good to have the same name for the local branch and the remote
> branch. If your local branch name is not in the form <yourname>/<branch
> name> you can rename your current branch by:
> 
> git branch -m <yourname>/<branch name>
> 
> 
> 2. Changing the remote url:
> ===========================
> When you setup your development environment, you would have cloned from
> a http url like http://git.yoctoproject.org/git/poky-contrib. You will
> not be able to push to this url and you will get an error like this:
> 
> fatal: unable to access 'http://git.yoctoproject.org/git/poky-
> contrib/': The requested URL returned error: 403
> 
> 
> You have to edit the remote url, by first checking the remote alias and
> url, and then changing the url.
> 
> You can view the remote aliases and the url by:
> 
> git remote --verbose
> 
> >>> This is the output on my machine:
> contrib http://git.yoctoproject.org/git/poky-contrib (fetch)
> contrib http://git.yoctoproject.org/git/poky-contrib (push)
> 
> ** Note contrib is my remote alias for poky-contrib
> 
> 
> For push, you have to change the url to git at git.yoctoproject.org:poky-
> contrib
> 
> You can change the url by:
> 
> git remote set-url contrib git at git.yoctoproject.org:poky-contrib
> 
> 
> After that you will able to push by:
> 
> git push contrib <yourname>/<branch name>
> 
> 
> Thanks,
> Ravi