[Toaster] git push to poky-contrib/ravi

[Barros Pena, Belen]

On 13/01/2014 06:01, "Reyna, David" <david.reyna at windriver.com> wrote:

>Hi Ravi,
>
>Here is my first pass review.
>
>1) I observe for your "...5ee1" commit there is no "Signed-off-by". Your
>other two commits do have that field.
>
>  $ git log
>  ...
>  commit 2848c7e9cdb37890c5f602dc5a8cebc5fad95ee1
>  Author: Ravi Chintakunta <ravi.chintakunta at timesys.com>
>  Date:   Thu Jan 9 22:08:09 2014 -0500
>
>    Django settings: Removed duplicate toastergui entry in INSTALLED_APPS
>
>  [[ no "Signed-off-by" ]]
>  ...
>
>2) It does not appear that you have the row context coloring based on the
>"outcome" value. I actually have that working in my new "recipe details"
>page (via my "outcome_highlight" helper method). We could share this
>implantation.
>
>3) It appears that "{% if not objects %}" is the same as "{% ifequal 0
>objects.count %}". If so, I can simplify my code accordingly.
>
>4) I observe that you have not implemented the href for the log file,
>presumably waiting for resolution of the questions you raised.
>
>Question for Belen. The sample All Tasks page from "yocto.com/toaster"
>has HREF links on all items in the table, but the design document has no
>reference as far as I can see to HREF usage.

Interactivity for each cell in the table is explained on page 8 (the last
one) of the design document (Design 1.3 All tasks) attached to

https://bugzilla.yoctoproject.org/show_bug.cgi?id=4275

There is a table in that page with an Interactivity column, where you can
see if the cell is a link and to where.

The following cells are links:

Order (to Task details page)
Recipe (to Recipe details page)
Recipe version (to recipe details page)
Task (to task details page)
Executed (to task details page)
Outcome (to task details page)
Cache attempt (to task details page)

Time, CPU, Disk I/O and Log are not links (Log will become a link at some
point, but first we need to work out how we are going to provide access to
log files for the remote use case: it does not make sense to have a link
for the local use case).

>
>5) Another question for Belen. The design document says that there are 3
>values for "Cache Attempt" (presumably mapping to "sstate_result", but
>SSTATE_RESULT has 4 values, not three. And none of them map to an empty
>display string, in contrast to the screen shot in the design document.

Good question: this is not explained properly anywhere (apologies). There
are indeed 4 sstate results:

SSTATE_NA - Not Applicable. This is for tasks that do not attempt to reuse
sstate objects. That value does not display on the table (the cell should
be blank)

SSTATE_MISS - Missing. This is for tasks that attempt to reuse an sstate
object but the object searched for does not exist. This value shows in the
table as "File not in cache"

SSTATE_FAILED - Failed. This is for tasks that attempt to reuse an sstate
object, the object is found but cannot be restored. This value shows in
the table as "Failed" and has the .warning class applied

SSTATE_RESTORED - Restored. This is for tasks that successfully reuse an
sstate object (i.e. Cached tasks). This value shows in the table as
"Succeeded"

Let me know if you have any questions.

Belén



>
>- David
>
> 
>
>> -----Original Message-----
>> From: Ravi Chintakunta [mailto:ravi.chintakunta at timesys.com]
>> Sent: Friday, January 10, 2014 9:11 AM
>> To: Reyna, David; Lerner, Dave; 'Damian, Alexandru'; 'Barros Pena,
>> Belen'; 'Zhang, Jessica'; Bansal, Atul
>> Cc: 'toaster at yoctoproject.org'
>> Subject: git push to poky-contrib/ravi
>> 
>> I got push access from Michael and pushed a small commit to ravi/all-
>> tasks-feature branch.
>> 
>> Just a few notes to help others with the first push.
>> 
>> 1. Changing the branch name:
>> ============================
>> It is good to have the same name for the local branch and the remote
>> branch. If your local branch name is not in the form <yourname>/<branch
>> name> you can rename your current branch by:
>> 
>> git branch -m <yourname>/<branch name>
>> 
>> 
>> 2. Changing the remote url:
>> ===========================
>> When you setup your development environment, you would have cloned from
>> a http url like http://git.yoctoproject.org/git/poky-contrib. You will
>> not be able to push to this url and you will get an error like this:
>> 
>> fatal: unable to access 'http://git.yoctoproject.org/git/poky-
>> contrib/': The requested URL returned error: 403
>> 
>> 
>> You have to edit the remote url, by first checking the remote alias and
>> url, and then changing the url.
>> 
>> You can view the remote aliases and the url by:
>> 
>> git remote --verbose
>> 
>> >>> This is the output on my machine:
>> contrib http://git.yoctoproject.org/git/poky-contrib (fetch)
>> contrib http://git.yoctoproject.org/git/poky-contrib (push)
>> 
>> ** Note contrib is my remote alias for poky-contrib
>> 
>> 
>> For push, you have to change the url to git at git.yoctoproject.org:poky-
>> contrib
>> 
>> You can change the url by:
>> 
>> git remote set-url contrib git at git.yoctoproject.org:poky-contrib
>> 
>> 
>> After that you will able to push by:
>> 
>> git push contrib <yourname>/<branch name>
>> 
>> 
>> Thanks,
>> Ravi
>