[Toaster] git push - set page title
Damian, Alexandru
alexandru.damian at intel.com
Thu Jan 16 09:02:50 PST 2014
Hello, Ravi.
I am gonna comment here on the whole set of patches :).
- Title: please use "bitbake: toaster: " as the start of all subject
lines. This helps with merging upstream, and makes some porting scripts
between oe-core and bitbake trees work :)
- Title needs to be a bit more descriptive. Ie. instead of "Base table
enhancements" - "Base table fix sorting header link and icon"
- Please squash all "All Tasks" patches in a single one, since functionally
it's all about a single thing - getting the task table to work.
The code itself looks good to me.
Cheers,
Alex
On Wed, Jan 15, 2014 at 8:02 PM, Ravi Chintakunta <
ravi.chintakunta at timesys.com> wrote:
> Hi Alex,
>
> I have pushed a commit to ravi/all-tasks-feature to set the page title if
> viewName is set in the context.
>
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=ad93ca464bf50fc798a507532feaeae02f9ba653
>
> Thanks,
> Ravi
>
--
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140116/e25e4384/attachment-0001.html>
More information about the toaster
mailing list