[Toaster] git push - set page title

[Ravi Chintakunta]

Hi Alex,

I completed the All tasks feature. I used rebase fixup / squash to edit the commit message, and group my commits into


-        Base html changes

-        Base table changes

-        Custom Tags

-        Filter Dialog

-        All tasks feature

With the rebase I am not able to push to my ravi/all-tasks-feature branch and I get this error:

To git at git.yoctoproject.org:poky-contrib
! [rejected]        ravi/all-tasks-feature -> ravi/all-tasks-feature (non-fast-forward)
error: failed to push some refs to 'git at git.yoctoproject.org:poky-contrib'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Merge the remote changes (e.g. 'git pull')


Is it OK to push with –f option.

Thanks,
Ravi

From: Damian, Alexandru [mailto:alexandru.damian at intel.com]
Sent: Thursday, January 16, 2014 12:03 PM
To: Ravi Chintakunta
Cc: toaster at yoctoproject.org
Subject: Re: git push - set page title

Hello, Ravi.

I am gonna comment here on the whole set of patches :).
- Title: please use  "bitbake: toaster: " as the start of all subject lines. This helps with merging upstream, and makes some porting scripts between oe-core and bitbake trees work :)
- Title needs to be a bit more descriptive. Ie. instead of "Base table enhancements" - "Base table fix sorting header link and icon"
- Please squash all "All Tasks" patches in a single one, since functionally it's all about a single thing - getting the task table to work.
The code itself looks good to me.

Cheers,
Alex


On Wed, Jan 15, 2014 at 8:02 PM, Ravi Chintakunta <ravi.chintakunta at timesys.com<mailto:ravi.chintakunta at timesys.com>> wrote:
Hi Alex,

I have pushed a commit to ravi/all-tasks-feature to set the page title if viewName is set in the context.

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=ad93ca464bf50fc798a507532feaeae02f9ba653

Thanks,
Ravi



--
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140117/6b199bbf/attachment.html>