[Toaster] FW: image information - 2nd pass w/ faked dirinfo backend
Lerner, Dave
dave.lerner at windriver.com
Fri Mar 7 14:49:47 PST 2014
Hi Belen,
1) lerner/imageinfo has been updated with fixes for everything that your evaluation found, except the issue with the help tooltip which I either don't understand or can't reproduce. Directory's themselves have the package field suppressed so I assumed you aren't talking about help bubbles on the directory rows, were you? See screen shot below.
2) settings.py was restored to the version that works in London.
3) Both pages have been html5 validated.
4) The changes for Alex's new schema are not yet implemented. Those changes only effect the directory structure page so the 'packages included' should be done.
The commit log reflects the latest set of changes.
Again, thanks for your detailed proof reading.
Dave
>>> b) The jquery treetable plugin adds icons like '>' (collapsed), and 'V'
>>> (expanded) to the rows. It may be hard to use that time-saving plugin
>>> without the icons.
>> This only bothers me when it is next to directories that have no content,
>> because it has a title attribute that says "Expand". It would be good to
>> hide it in those cases, if at all possible.
Fixed. An oversight on my part.
> > * The size over total should be calculated over the sum of the sizes of
> > all the packages in the table, which means we should be able to add that
> > information in
> >
Done
>
> > * In the Dependencies and Reverse dependencies popovers, each package is
> > coming in twice (for example, for base-password, you get a 2 in the
> > Dependencies button, and when you click it the popover shows ³busybox,
> > busybox².
Done
> >
> > * We need to implement the no results page for the search / filters. Once
> > more, we should be able to reuse what is in builds.html
>
Done (misread the comment first pass)
> >
> > * Right now the only sortable column seems to be Package. The following
> > columns should be sortable as well: Size, Size over total (%), License,
> > Recipe, Layer, Layer branch and Layer directory
>
Done
>
>
> >
> > * I am happy with the ³ ³ wrapping the installed_name, but if we add them
> > in the Directory structure tab, we should also add them in the Packages
> > included tab to keep the presentation nice and consistent :) Otherwise, we
> > take them out of the Directory structure tab. I am happy with any of the 2.
Done. Quotes around installed package name removed.
> > * We need an extra space between the installed_name and help bubble. I
> > just added an space in line 103 right before the <i> tag and that works
> > fine
Done.
> > * For some reason, the help tooltips don¹t seem to be working when they
> > are inside a directory. The .hover-help class does not set the visibility
> > to hidden, and the Bootstrap tooltips don¹t start up. I am not sure if
> > this is some weird interaction with the table plugin. They do work in the
> > ones at the bottom of the table, which are shown by default. If we cannot
> > get them to work, we will need to take them out. Maybe Farrell might be
> > able to give us a hand with this.
> >
I can't reproduce your problem. The hover help takes a while to appear, but appears on a browser on the server and a remote browser. Or are you talking about the 'collapse' 'expand' hover tip?
[cid:image001.png at 01CF3A1B.A93C19D0]
> > >
> > >> -----Original Message-----
> > >> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
> > >> Sent: Wednesday, March 05, 2014 12:39 PM
> > >> To: Lerner, Dave; DAMIAN, ALEXANDRU; Reyna, David; Paul Eggleton
> > >> (paul.eggleton at linux.intel.com)
> > >> Subject: Re: image information - problems with database after Paul's
> > >>push
> > >>
> > >>
> > >> On 05/03/2014 00:07, "Lerner, Dave" <dave.lerner at windriver.com> wrote:
> > >>
> > >> >My new branch for the image 'packages included' and 'directory
> > >>structure
> > >> >(fake backend)' is in lerner/imaginfo.
> > >>
> > >> Hi Dave,
> > >>
> > >> I tried your branch, but when I sourced toaster first I got an error
> > >> complaining about pytz. I installed pytz and when I sourced toaster
> > >>again
> > >> I got this other error:
> > >>
> > >> The system will start.
> > >> Traceback (most recent call last):
> > >> File "/home/yocto/poky/bitbake/bin/../lib/toaster/manage.py", line 10,
> > >> in <module>
> > >> execute_from_command_line(sys.argv)
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 453, in execute_from_command_line
> > >> utility.execute()
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 392, in execute
> > >> self.fetch_command(subcommand).run_from_argv(self.argv)
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 263, in fetch_command
> > >> app_name = get_commands()[subcommand]
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 109, in get_commands
> > >> apps = settings.INSTALLED_APPS
> > >> File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line
> > >> 52, in __getattr__
> > >> self._setup(name)
> > >> File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line
> > >> 47, in _setup
> > >> self._wrapped = Settings(settings_module)
> > >> File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line
> > >> 132, in __init__
> > >> raise ImportError("Could not import settings '%s' (Is it on
> > >> sys.path?): %s" % (self.SETTINGS_MODULE, e))
> > >> ImportError: Could not import settings 'toastermain.settings' (Is it on
> > >> sys.path?): No module named tzlocal
> > >> Traceback (most recent call last):
> > >> File "/home/yocto/poky/bitbake/bin/../lib/toaster/manage.py", line 10,
> > >> in <module>
> > >> execute_from_command_line(sys.argv)
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 453, in execute_from_command_line
> > >> utility.execute()
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 392, in execute
> > >> self.fetch_command(subcommand).run_from_argv(self.argv)
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 263, in fetch_command
> > >> app_name = get_commands()[subcommand]
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 109, in get_commands
> > >> apps = settings.INSTALLED_APPS
> > >> File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line
> > >> 52, in __getattr__
> > >> self._setup(name)
> > >> File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line
> > >> 47, in _setup
> > >> self._wrapped = Settings(settings_module)
> > >> File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line
> > >> 132, in __init__
> > >> raise ImportError("Could not import settings '%s' (Is it on
> > >> sys.path?): %s" % (self.SETTINGS_MODULE, e))
> > >> ImportError: Could not import settings 'toastermain.settings' (Is it on
> > >> sys.path?): No module named tzlocal
> > >>
> > >> Error on migration, trying to recover...
> > >>
> > >> Traceback (most recent call last):
> > >> File "/home/yocto/poky/bitbake/bin/../lib/toaster/manage.py", line 10,
> > >> in <module>
> > >> execute_from_command_line(sys.argv)
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 453, in execute_from_command_line
> > >> utility.execute()
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 392, in execute
> > >> self.fetch_command(subcommand).run_from_argv(self.argv)
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 263, in fetch_command
> > >> app_name = get_commands()[subcommand]
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 109, in get_commands
> > >> apps = settings.INSTALLED_APPS
> > >> File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line
> > >> 52, in __getattr__
> > >> self._setup(name)
> > >> File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line
> > >> 47, in _setup
> > >> self._wrapped = Settings(settings_module)
> > >> File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line
> > >> 132, in __init__
> > >> raise ImportError("Could not import settings '%s' (Is it on
> > >> sys.path?): %s" % (self.SETTINGS_MODULE, e))
> > >> ImportError: Could not import settings 'toastermain.settings' (Is it on
> > >> sys.path?): No module named tzlocal
> > >> Traceback (most recent call last):
> > >> File "/home/yocto/poky/bitbake/bin/../lib/toaster/manage.py", line 10,
> > >> in <module>
> > >> execute_from_command_line(sys.argv)
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 453, in execute_from_command_line
> > >> utility.execute()
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 392, in execute
> > >> self.fetch_command(subcommand).run_from_argv(self.argv)
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 263, in fetch_command
> > >> app_name = get_commands()[subcommand]
> > >> File
> > >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",
> > >> line 109, in get_commands
> > >> apps = settings.INSTALLED_APPS
> > >> File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line
> > >> 52, in __getattr__
> > >> self._setup(name)
> > >> File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line
> > >> 47, in _setup
> > >> self._wrapped = Settings(settings_module)
> > >> File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line
> > >> 132, in __init__
> > >> raise ImportError("Could not import settings '%s' (Is it on
> > >> sys.path?): %s" % (self.SETTINGS_MODULE, e))
> > >> ImportError: Could not import settings 'toastermain.settings' (Is it on
> > >> sys.path?): No module named tzlocal
> > >> Failed start.
> > >>
> > >>
> > >> I am guessing this is related to the timezone fix, but I don't know how
> > >>to
> > >> work around it. Any ideas?
> > >>
> > >> Thanks!!
> > >>
> > >> Belén
> > >>
> > >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/509c5693/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 24914 bytes
Desc: image001.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/509c5693/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.png
Type: image/png
Size: 20320 bytes
Desc: image002.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/509c5693/attachment-0007.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image003.png
Type: image/png
Size: 29764 bytes
Desc: image003.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/509c5693/attachment-0008.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image004.png
Type: image/png
Size: 9903 bytes
Desc: image004.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/509c5693/attachment-0009.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image005.png
Type: image/png
Size: 19085 bytes
Desc: image005.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/509c5693/attachment-0010.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 19695 bytes
Desc: image001.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/509c5693/attachment-0011.png>
More information about the toaster
mailing list