[Toaster] image information - 2nd pass w/ faked dirinfo backend

[Barros Pena, Belen]

On 07/03/2014 22:49, "Lerner, Dave" <dave.lerner at windriver.com> wrote:

>>> * For some reason, the help tooltips don¹t seem to be working when they
>>> are inside a directory. The .hover-help class does not set the
>>>visibility
>>> to hidden, and the Bootstrap tooltips don¹t start up. I am not sure if
>>> this is some weird interaction with the table plugin. They do work in
>>>the
>>> ones at the bottom of the table, which are shown by default. If we
>>>cannot
>>> get them to work, we will need to take them out. Maybe Farrell might be
>>> able to give us a hand with this.
>>>
>I can’t reproduce your problem. The hover help takes a while to appear,
>but appears on a browser
>on the server and a remote browser.  Or are you talking about the
>‘collapse’ ‘expand’ hover tip?
>

I am talking about the help bubble next to the packages that have name !=
installed_name in the Directory structure table. When you go to that page
with your database, you can see some symlinks at the very bottom (bin,
lib, lib64 and sbin). If you roll over the "Source package" cell for bin,
for example, you will see the help bubble coming up, and if you hover over
the help bubble, you will see that the tooltip has a black background with
white font.

If you expand a directory, for example 'var', you will that the "Source
package" cell for the symlinks is shown always (instead of appearing when
you hover over the cell) and when you hover over it the tooltip style is
the one set by your browser (in mine is black font on a grey background).

>>
>> * We need to implement the no results page for the search / filters.
>>Once
>> more, we should be able to reuse what is in builds.html
>

The h1 is saying "no packages". We should probably keep it consistent with
the other Toaster pages and say "0 packages found"


I am afraid I have a few more comments (*ducks*):

* In the packages included table, installed_name doesn't seem to be
searchable. Can we make it searchable so that if I search for libc6 in a
core-image-minimal target the search will return eglibc?


* In the directory structure table, the cells with clickable directories
include the following markup before the <a> tag that includes the icon.
 
<span class="indenter" style="padding-left:0px;">
<a href="#"> </a>
</span>

This seems to be coming from the expanderTemplate and indenterTemplate
settings in jquery.treetable.js and cause the clickable and non-clickable
directories to not align properly. Removing the ' ' from
expanderTemplate fixes the alignment problem, but still leaves the empty
span and anchor tag inside the cell. Ideally, our content (i.e. the icon +
the directory name) would go inside the expanderTemplate whenever the
folder is clickable, so that we don't need to add our own <a> tag. It
should be possible to inject content inside the anchor tag in
expanderTemplate from dirinfo.html using the append() jQuery function.

$('.indenter > a').append("mark up to be appended here");

If the folder is not clickable, we could remove the <a> tag inside the
expanderTemplate before adding the icon and the directory name

$('.indenter > a').remove();
$('.indenter').append("mark up to be appended here");


This would save us some markup per table row, which is always good :)

* dirinfo.html in line 131 uses an inline style to set the right colour
for the class icon-hand-right. We should probably set that in default.css
instead and get rid of the inline style declaration.

* We should probably comment out lines 60, 90, 429 and 430 in
jquery.treetable.js, which set the title tag for the arrow link, since we
are not using those arrows any more and the title still shows if you hover
over the span to the left of the folder icon.

* Do we need jquery.treetable.theme.toaster.css?  I am not sure about what
it does.

Any questions, let me know.

Cheers

Belén