[Toaster] image information - 2nd pass w/ faked dirinfo backend

[Lerner, Dave]

Partial response.  Still working on the rest...

> -----Original Message-----
> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
> Sent: Monday, March 10, 2014 11:36 AM
> To: Lerner, Dave
> Cc: toaster at yoctoproject.org
> Subject: Re: image information - 2nd pass w/ faked dirinfo backend
> 
> On 07/03/2014 22:49, "Lerner, Dave" <dave.lerner at windriver.com> wrote:
> 
> >>> * For some reason, the help tooltips don¹t seem to be working when they
> >>> are inside a directory. The .hover-help class does not set the
> >>>visibility
> >>> to hidden, and the Bootstrap tooltips don¹t start up. I am not sure if
> >>> this is some weird interaction with the table plugin. They do work in
> >>>the
> >>> ones at the bottom of the table, which are shown by default. If we
> >>>cannot
> >>> get them to work, we will need to take them out. Maybe Farrell might be
> >>> able to give us a hand with this.
> >>>
> >I can't reproduce your problem. The hover help takes a while to appear,
> >but appears on a browser
> >on the server and a remote browser.  Or are you talking about the
> >'collapse' 'expand' hover tip?
> >
> 
> I am talking about the help bubble next to the packages that have name !=
> installed_name in the Directory structure table. When you go to that page
> with your database, you can see some symlinks at the very bottom (bin,
> lib, lib64 and sbin). If you roll over the "Source package" cell for bin,
> for example, you will see the help bubble coming up, and if you hover over
> the help bubble, you will see that the tooltip has a black background with
> white font.

I finally get it! the hover question mark bubble unconditionally appears in an expanded row.  I'll fix this.

But...
> If you expand a directory, for example 'var', you will that the "Source
> package" cell for the symlinks is shown always (instead of appearing when
> you hover over the cell) and when you hover over it the tooltip style is
> the one set by your browser (in mine is black font on a grey background).

You will have to show me this problem I'm afraid.  Because the data is _NOT_ coming from my database, but is from your server host or my server host, ie 'faked backend'. What happens on my host may not match what is happening on your host.  

Specifically when you say ...
> "Source package" cell for the symlinks is shown always 
> (instead of appearing when you hover over the cell)
... I'm not sure what you mean.  Source package cell is unconditional, symlink or not, if the inode is not a directory, according to how I interpretted the spec. 

I'm sure a webex session will clear this up quickly if I can schedule one with you.

> >>
> >> * We need to implement the no results page for the search / filters.
> >>Once
> >> more, we should be able to reuse what is in builds.html
> >
> 
> The h1 is saying "no packages". We should probably keep it consistent with
> the other Toaster pages and say "0 packages found"

I was following the code below from recipes and tasks, which may have bugs:
recipes.html
<h1>
  {% if request.GET.filter or request.GET.search and objects.count > 0  %}
      {{objects.paginator.count}} recipe{{objects.paginator.count|pluralize}} found
  {%elif objects.paginator.count == 0%}
      No Recipes
  {%else%}
      Recipes
  {%endif%}
 </h1>

tasks.html
<h1>
  {% if request.GET.filter or request.GET.search and objects.count > 0  %}
      {{objects.paginator.count}} task{{objects.paginator.count|pluralize}} found
  {%elif objects.paginator.count == 0%}
      No tasks
  {%else%}
      {{title}}
  {%endif%}
 </h1>
---------------
As you can see, both recipes and tasks have the intention of showing "No recipes" and "No tasks" but because the code tests objects.count instead of objects.paginator.count the logic fails and they use the "0 found" reporting method insted of intended "N ..."

my code - target.html - correctly tests objects.paginator.count > 0
<h1>
  {% if request.GET.search and objects.paginator.count > 0 %}
     {{objects.paginator.count}} package{{objects.paginator.count|pluralize}} found
  {% elif request.GET.search and objects.paginator.count == 0 %}
     No packages
  {% else %}
     {{target.target}} 
  {% endif %} 
</h1>

I will change my code to use "0 <entities> found" (without the bugs), but then we need a bug report to remove the dead code and the bugs from recipes.html and tasks.html, so that they don't get 'fixed' and become inconsistent with my code, correct?

(still reviewing the rest)
Dave