[Toaster] [review-request] V2: Review request for Bug 5947 - Replace fstypes lookup on main build page

[Reyna, David]

Hi Alex,

Thank you for the information.

FYI, I did complete my implementation, moving the helper routine from the filter to the view class, and the help of one added filter that does generic dictionary lookups (to support keys that have “.” In them). I also added code for the special case of “tar.bz2”, since the design document wants two extensions to show and not just the last extension.

This is for your pre-review, since as you say we need to postpone until we are in sync again.

Updated branch:  dreyna/fstypes

BTW, given your description of the upcoming data collection change, I am not sure this code would need to be any different.

In any case, let me know when the master is back in sync and the data collection change has happened so I can rebase and retest, unless you really want to take this case back and hopefully use my update.

- David

From: Damian, Alexandru [mailto:alexandru.damian at intel.com]
Sent: Friday, March 21, 2014 2:13 AM
To: Reyna, David
Cc: Wymore, Farrell; toaster at yoctoproject.org
Subject: Re: [Toaster] Review request for Bug 5947 - Replace fstypes lookup on main build page

Hi David,
I have the reverting patch up for submission. Unfortunately, the next merging upstream will not happen until Monday. Can you please postpone this one until we settle the upstream master ?
There is also another patch that tries to tackle this problem at data collection time; if we manage to get that one in, that this patch will have to have a different form. I think I will tackle it to save time, so please reassign the bug to me.
What that does  is basically cross-reference the collected output file names with the IMAGE_FSTYPES variable and register directly the only output extensions that are valid.

Hope this helps,
Alex

On Fri, Mar 21, 2014 at 7:18 AM, Reyna, David L (Wind River) <david.reyna at windriver.com<mailto:david.reyna at windriver.com>> wrote:
Hi Alex,

I can and will redo the commit. Did you revert the original patch?

I did a pull at 11:00 pm 2014/3/20 and I still see the patch. If you allow me to revert it explicitly with the updated patch, then you do not need to revert and I do not need to rebase yet again and lose a day, nor would anyone else preparing commits with changes to “projecttags.py”.

Also, we are seeing image file entries like “rootfs.manifest”. How does the algorithm know that “rootfs.tar.bz2” and “rootfs.ext3” are image files,  but ‘rootfs.manifest” is not? Or is the issue that entries like “rootfs.manifest” should not be in the image file list in the first place?

- David

From: toaster-bounces at yoctoproject.org<mailto:toaster-bounces at yoctoproject.org> [mailto:toaster-bounces at yoctoproject.org<mailto:toaster-bounces at yoctoproject.org>] On Behalf Of Damian, Alexandru
Sent: Thursday, March 20, 2014 4:45 AM
To: Wymore, Farrell
Cc: toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
Subject: Re: [Toaster] Review request for Bug 5947 - Replace fstypes lookup on main build page

Hi,

I made a sloppy job reviewing this patch, I'm sorry for this.

The filters should have no knowledge of the object system. All object manipulation should happen only in the views.py page, and relevant values passed through the context.

I'm reverting this patch for the 2014/03/20 submission. Can you please rework this patch with the relevant data queries inside views.py ?

Thank you,
Alex

On Fri, Mar 14, 2014 at 5:37 PM, Damian, Alexandru <alexandru.damian at intel.com<mailto:alexandru.damian at intel.com>> wrote:
Taken in.

On Tue, Mar 11, 2014 at 11:00 PM, Wymore, Farrell <Farrell.Wymore at windriver.com<mailto:Farrell.Wymore at windriver.com>> wrote:
Hi Belen,

I  have pushed the fix for this defect.
    fwymore/fstypes

Thanks in advance - fw

--
_______________________________________________
toaster mailing list
toaster at yoctoproject.org<mailto:toaster at yoctoproject.org>
https://lists.yoctoproject.org/listinfo/toaster



--
Alex Damian
Yocto Project
SSG / OTC



--
Alex Damian
Yocto Project
SSG / OTC



--
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140321/3257a154/attachment-0001.html>