[Toaster] Design conflict around "basebuildpage.html" for 4258 and 5916

[Damian, Alexandru]

On Fri, Mar 21, 2014 at 11:20 AM, Barros Pena, Belen <
belen.barros.pena at intel.com> wrote:

> On 21/03/2014 07:06, "Reyna, David" <david.reyna at windriver.com> wrote:
>
> >Hi Belen and Alex,
> >
> >Alex wrote with regards to the Build Dashboard (4258) review request:
> >
> >  "isDashboardPage" seems to be targeting only the dashboard page; I'm
> >not sure that cluttering base template files with page-specific code is a
> >good idea, as it will lead to lots of very complicated code moving
> >forward. I would suggest dropping this enhancement since it only affects
> >whenever a link is enabled or not, the easy thing to do is just display
> >the link at all times. If this is unacceptable, it is better to break the
> >needed content into a block, and override this block in the
> >dashboard-specific page.
> >
> >I have two requirements that affect the navigation box, the above
> >dashboard page instance plus this requirement:
>
> Sorry, David, I am not sure I follow: how is isDashboardPage affecting the
> left navigation?  I can see that it is used to wrap the build identifier
> in the breadcrumb inside an <a> tag when the page is not a dashboard page,
> but I am not sure if it does anything else.
>
> By the way, this is needed: the breadcrumb must behave consistently across
> all pages, which means that its latest item must have the 'active' class
> applied and must not be a link.
>
> >   5916 "The current page should have its left navigation item
> >highlighted"
> >
> >I suspect that you Belen would like to keep your design. To satisfy Alex,
> >I can therefore implement both requirements using blocks, where each page
> >would override its respective block with highlighting and/or hiding as
> >appropriate.
>
>
​Yep, this is what I had in mind, thank you !​

​Alex​



> If this is the way of implementing the breadcrumb and the navigation as
> designed, it is good for me. I am not sure what Alex thinks.
>
> Thanks!
>
> Belén
>
> >
> >Do you two accept this proposal?
> >
> >Thanks,
> >David
> >
> >
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140324/938fe7bf/attachment-0001.html>