[Toaster] Review of "all machines" page

[Michael Wood]

Latest Update 3
HEAD cd28aecfa1119d31b085ff7eb4447e138ac76eb2
poky-contrib michaelw/all-machines

>> * In the no results page, the word "Machines" in the heading should not be
>> capitalised, to match all other states of the heading
> Fixed (update 3)

> * Something funny going on with the layers: the openembedded-core layer
> appears as if it is not added to the project, but it is definitely added
> (it is added by default to all our projects). What's worse, when you click
> on 'add layer', you actually end up with 2 openembedded-core layers added
> to the project. When you hover over the second one, it seems to be coming
> from the oe repo, instead of the poky repo, and has not branch. I am not
> sure how up-to-date your branch is with master. If it is fully up-to-date,
> something has broken down with the layers :/

Fixed (update 3)

Yes Alex was explaining that this was likely to happen because we'll see 
duplicates if we get the same layer but from a different source. It's 
going to make the page pretty slow.

>> * Also in the no results page, the "show all machines" link is not
>> working. When you click on it, nothing happens.
> Fixed (update 3)

>>>
>>> * The "Show rows" menu doesn't seem to be working properly. When you 
>>> load
>>> the page, the table always shows 10 rows, independently of the value
>>> selected in the "show rows" menu
>> Fixed
>>
>>>
>>> * The machine name should not have a blue icon next to it
>> Fixed
>>>
>>> * The machine file information is not coming in
>> Unfortunately we have no information available on the machine file 
>> that I can find to display
>>
>
> Fixed (update 2)
>
>>>
>>> * The layer name should be a link to the layer details page
>> Fixed
>>>
>>> * The branch, tag or commit column always shows a commit. For machines
>>> coming from layers from the OpenEmbedded layer source, this column 
>>> should
>>> be showing a branch name instead
>>>
>
> Fixed (update 2)
>
>
>>> * The help text in the "add layer" buttons is currently hardcoded (it
>>> shows the same layer name for all machines)
>> Fixed
>>>
>>> * You cannot add layers / select machine functionality is not in place
>> Fixed - Apart from the funny tooltip thing will come back to this
>>>
>>> * The 'layer' column should be sortable (currently isn't)
>
> Fixed (update 2)
>
>>>
>>> * Sorting and the "edit columns" menu do not interact as explained 
>>> in page
>>> 21 of the design document
>>>
Fixed (update 3)
>>> * Sorting by layer source reverts the sorting by machine, setting it 
>>> to z
>>> to a. This should not happen: when I sort by layer source, machines 
>>> with
>>> the same layer source should be sorted in alphabetical order (a to z)
>

Fixed I think (update 3)

>>>
>>> * The "select" column filter is not in place
>>>
>
> Fixed (update 2)
>
>>> * When applying a filter, the page heading does not update to show the
>>> number of results returned by the filter
>>>
>
>
> Was this for filters or Search? I've implemented it for search but I 
> didn't see in the designs the same thing happens for filters.
> A: Both
Fixed (update 3)


Things coming back to also for layerdetails
  - Funny tooltip thing
  - machine change confirm

Michael