[Toaster] Review of "all machines" page

[Barros Pena, Belen]

On 05/02/2015 19:00, "Michael Wood" <michael.g.wood at intel.com> wrote:

>Latest Update 3
>HEAD cd28aecfa1119d31b085ff7eb4447e138ac76eb2
>poky-contrib michaelw/all-machines

The show rows menu seems to be acting up again :/ When you select a value,
nothing happens

>
>> * Something funny going on with the layers: the openembedded-core layer
>> appears as if it is not added to the project, but it is definitely added
>> (it is added by default to all our projects). What's worse, when you
>>click
>> on 'add layer', you actually end up with 2 openembedded-core layers
>>added
>> to the project. When you hover over the second one, it seems to be
>>coming
>> from the oe repo, instead of the poky repo, and has not branch. I am not
>> sure how up-to-date your branch is with master. If it is fully
>>up-to-date,
>> something has broken down with the layers :/
>
>Fixed (update 3)

It's not working for me: the machines provided by layers added to the
project now don't show at all in the all machines page. You can check it
out using the filter in the 'select' column. It says that the number of
machines provided by layers added to the project is 0.

>>>> * Sorting by layer source reverts the sorting by machine, setting it
>>>> to z
>>>> to a. This should not happen: when I sort by layer source, machines
>>>> with
>>>> the same layer source should be sorted in alphabetical order (a to z)
>>
>
>Fixed I think (update 3)

It's not working for me. When I sort by layer source, I still get the zynq
machine at the top of the page (sorting by that column is also sorting the
machines from z to a for some reason).

>
>>>>
>>>> * The "select" column filter is not in place
>>>>
>>
>> Fixed (update 2)
>>
>>>> * When applying a filter, the page heading does not update to show the
>>>> number of results returned by the filter
>>>>
>>
>>
>> Was this for filters or Search? I've implemented it for search but I
>> didn't see in the designs the same thing happens for filters.
>> A: Both
>Fixed (update 3)
>
>
>Things coming back to also for layerdetails
>  - Funny tooltip thing
>  - machine change confirm

Do you want me to open issues for this?

Thanks!!

Belén

>
>Michael