[Toaster] [review-request] adamian/20150515_fix_table_header - REST refactoring

Michael Wood michael.g.wood at intel.com
Wed Jun 3 06:59:49 PDT 2015


8305ee985bdc87dcfb63be4e0ddafb0a9239ffd4

Looks good to me.

Yeah that's a good idea to make ToasterTable inherit from TemplateView 
rather than have it in between.

Thanks,

Michael


On 03/06/15 14:15, Damian, Alexandru wrote:
> Hi,
>
> I've progressed a bit with the REST refactoring, I've tackled the 
> ToasterTables. Thanks to good quality of the existing code , changing 
> the layout of the URL was straightforward.
>
> adamian/20150515_fix_table_header
>
> This reduces the number of entry points for the URL, removes the ugly 
> hardcoding of XHR_ table urls in tables.py, and makes sure the APIs 
> are both human- and machine-readable.
>
> I'll continue with refactoring to remove the xhr_datatypeahead and 
> similar URL endpoints which should not have existed in the first place.
>
> Cheers,
> Alex
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
>



More information about the toaster mailing list