[Toaster] [review-request] adamian/20150515_fix_table_header - REST refactoring

Damian, Alexandru alexandru.damian at intel.com
Wed Jun 3 07:35:27 PDT 2015


Thanks -

I'm pushing new patches to bring more parts of the system in conformance -
just removed xhr_project(info|edit) in favor of JSON-based "project" page.

I will update on this thread when I tackled the bugs highlighted on the
other thread, and when the new functionality is ready to merge from my POV.

Alex

On Wed, Jun 3, 2015 at 2:59 PM, Michael Wood <michael.g.wood at intel.com>
wrote:

>
> 8305ee985bdc87dcfb63be4e0ddafb0a9239ffd4
>
> Looks good to me.
>
> Yeah that's a good idea to make ToasterTable inherit from TemplateView
> rather than have it in between.
>
> Thanks,
>
> Michael
>
>
>
> On 03/06/15 14:15, Damian, Alexandru wrote:
>
>> Hi,
>>
>> I've progressed a bit with the REST refactoring, I've tackled the
>> ToasterTables. Thanks to good quality of the existing code , changing the
>> layout of the URL was straightforward.
>>
>> adamian/20150515_fix_table_header
>>
>> This reduces the number of entry points for the URL, removes the ugly
>> hardcoding of XHR_ table urls in tables.py, and makes sure the APIs are
>> both human- and machine-readable.
>>
>> I'll continue with refactoring to remove the xhr_datatypeahead and
>> similar URL endpoints which should not have existed in the first place.
>>
>> Cheers,
>> Alex
>>
>> --
>> Alex Damian
>> Yocto Project
>> SSG / OTC
>>
>>
>>
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20150603/d1931b4b/attachment.html>


More information about the toaster mailing list