[Toaster] [review-request] adamian/20150515_fix_table_header - REST refactoring

[Barros Pena, Belen]

Hi Alex,

I've had a quick look at this branch. Table headings are back :) but found
a couple of things:

* the layer dependencies check is not working. When I add a layer with
dependencies, I am not prompted to add them.
* the autocomplete functionality is not working. I always get the same
suggestions independently of what I type
* the new build button in pages belonging to a project shows the recipe
text field and build buttons disabled, even though there is a project
selected. 
* trying to change the project release throws the following error:

Release matching query does not exist.
Traceback (most recent call last):
  File "/home/yocto/master/bitbake/lib/toaster/toastergui/views.py",
line 2393, in xhr_datatypeahead
    lv = prj.compatible_layerversions(release =
Release.objects.get(pk=request.GET.get('search',
None))).filter(layer__name = i.layercommit.layer.name)
  File 
"/usr/local/lib/python2.7/dist-packages/django/db/models/manager.py",
line 151, in get
    return self.get_queryset().get(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py",
line 307, in get
    self.model._meta.object_name)
DoesNotExist: Release matching query does not exist.

The rest seems to be working ok, as far as I can see.


Thanks!

On 03/06/2015 15:35, "Damian, Alexandru" <alexandru.damian at intel.com>
wrote:

>Thanks - 
>
>
>I'm pushing new patches to bring more parts of the system in conformance
>- just removed xhr_project(info|edit) in favor of JSON-based "project"
>page.
>
>
>I will update on this thread when I tackled the bugs highlighted on the
>other thread, and when the new functionality is ready to merge from my
>POV.
>
>
>Alex
>
>
>On Wed, Jun 3, 2015 at 2:59 PM, Michael Wood
><michael.g.wood at intel.com> wrote:
>
>
>8305ee985bdc87dcfb63be4e0ddafb0a9239ffd4
>
>Looks good to me.
>
>Yeah that's a good idea to make ToasterTable inherit from TemplateView
>rather than have it in between.
>
>Thanks,
>
>Michael
>
>
>
>On 03/06/15 14:15, Damian, Alexandru wrote:
>
>Hi,
>
>I've progressed a bit with the REST refactoring, I've tackled the
>ToasterTables. Thanks to good quality of the existing code , changing the
>layout of the URL was straightforward.
>
>adamian/20150515_fix_table_header
>
>This reduces the number of entry points for the URL, removes the ugly
>hardcoding of XHR_ table urls in tables.py, and makes sure the APIs are
>both human- and machine-readable.
>
>I'll continue with refactoring to remove the xhr_datatypeahead and
>similar URL endpoints which should not have existed in the first place.
>
>Cheers,
>Alex
>
>-- 
>Alex Damian
>Yocto Project
>SSG / OTC
>
>
>
>
>
>
>
>---------------------------------------------------------------------
>Intel Corporation (UK) Limited
>Registered No. 1134945 (England)
>Registered Office: Pipers Way, Swindon SN3 1RJ
>VAT No: 860 2173 47
>
>This e-mail and any attachments may contain confidential material for
>the sole use of the intended recipient(s). Any review or distribution
>by others is strictly prohibited. If you are not the intended
>recipient, please contact the sender and delete all copies.
>
>
>
>
>
>
>
>
>-- 
>Alex Damian
>Yocto Project
>
>SSG / OTC 
>
>
>