[Toaster] [review-request] 6040 and 7249: daterange filtering for builds page

[Reyna, David]

Hi Belén,

> The spec says "The date format is DD/MM/YYYY." 

Ok. 

> I understand that the tuple/list is how it's done else...

I have finished refactored the date range data passing and storage (using context variables and "data-*" attributes instead), so no more extra tuple values. 

I just have to finish the "filter" munging to remove the need for the URL redirect, and I should have Michael's issues resolved.

> 7461 "Filters not working as designed"

Ok, I have the data counts removed and the radio button enables adjusted. I made the change only in the presentation so that we do not lose the calculations and structure we currently have in place.

- David

> -----Original Message-----
> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
> Sent: Friday, March 20, 2015 2:54 AM
> To: Reyna, David; WOOD, MICHAEL; DAMIAN, ALEXANDRU
> Cc: toaster at yoctoproject.org
> Subject: Re: [Toaster] [review-request] 6040 and 7249: daterange filtering
> for builds page
> 
> 
> 
> On 19/03/2015 22:43, "Reyna, David" <david.reyna at windriver.com> wrote:
> >
> >  1) Belén wants the edit date fields in "dd/mm/yy", so they do have to
> >be converted at some point to and from the database format.
> 
> The spec says "The date format is DD/MM/YYYY." See page 9 of
> 
> https://bugzilla.yoctoproject.org/attachment.cgi?id=1708
> 
> That is misleading (sorry). What it should have said is "The date format
> is the same format used to display the dates in the 'from' and 'to' text
> fields".
> 
> >>
> >> I understand that the tuple/list is how it's done else where but
> >> unfortunately this is not correct it's not a good idea to rely on the
> >> fact that the date option is the 4th option, anyone changing that will
> >> not realise it and it will all break.
> >
> >[DLR] I am just following the model that Belén set up.
> 
> Please don't :) Once again, the prototype code should not be used as a
> reference for development: only the way the prototype looks like and
> behaves. The only purpose of the prototype is to bring the design specs to
> life, so that they are easier to follow. The code should not be reused in
> any way (it's very bad code!).
> 
> Cheers,
> 
> Belén
>