[Toaster] [PATCH v5 00/19] per project build directory

[Barros Pena, Belen]

On 17/03/2016 16:22, "Ed Bartosh" <ed.bartosh at linux.intel.com> wrote:

>Hi Belen,
>
>Thank you for testing!
>
>See my comments below.
>
>On Thu, Mar 17, 2016 at 05:20:59PM +0000, Barros Pena, Belen wrote:
>> On 16/03/2016 12:05, "toaster-bounces at yoctoproject.org on behalf of Ed
>> Bartosh" <toaster-bounces at yoctoproject.org on behalf of
>> ed.bartosh at linux.intel.com> wrote:
>> 
>> >Hi,
>> >
>> >Default build directory is not going to be used for project builds
>> >anymore.
>> >It can be used only for command line builds. Toaster will use
>> >build-toaster-<project id>
>> >directories for project builds.
>> 
>> FWIW, this seems to be working for me. I have built master, jethro,
>>local
>> and from cli. 
>> 
>> Some things to keep in mind, once the series is upstream:
>> 
>> 1. Projects should be sharing sstate and downloads directories by
>>default.
>> Right not they don't, and my testing because of that was painfully slow
>>(I
>> had to run a clean build every time). I am not sure if Sujith's patches
>> are enough for this
>> 
>>(https://lists.yoctoproject.org/pipermail/toaster/2016-February/003832.ht
>>ml
>> ) or if something else needs to be done. Ed: would you be able to have a
>> look to Sujith's branch once you are done with this
>>
>Sure, I'm going to look at it.
>
>What should be default values for DL_DIR and SSTATE_DIR?
>Would something like $(TOPDIR)/../downloads and $(TOPDIR)/../sstate-cache
>be ok?

That looks ok to me.

>
>> 2. No toaster_ui.log file is created inside the /build directory, which
>>is
>> where cli builds are run. This might be expected, though.
>>
>Are you sure?
>They should be created in build-toaster-<project id>/ directories.

Yes, you have them inside the build-toaster-* directories, but not in the
/build directory (where cli builds happen). But as I said, that might be
expected. 

>
>> 3. The _meta-toaster-custom layer for the custom images should be
>>created
>> inside each project build directory: it should not be shared across
>> projects (right now it is, since it is in the source root directory)
>>
>Makes sense to me. I'll try to do it after looking at Sujith patchset.
>
>Regards,
>Ed
>
>> Cheers
>> 
>> Belén
>> 
>> >
>> >This is how to test this:
>> > - run toaster
>> > - run command line build: build zlib
>> > - check if it's shown in Toaster UI
>> > - create project for Yocto master
>> > - trigger project build from UI
>> > - wait until it succeeds
>> > - create project for Jethro
>> > - trigger project build from UI
>> > - wait until it succeds
>> > - check that 2 build directories build-toaster-<project id> exist and
>> >contain
>> >   correct conf/toaster.conf and conf/bblayers.conf
>> >
>> >Changes in v2: stop bitbake server after the build
>> >Changes in v3: fixed '/bin/sh: 1: source: not found' dash issue
>> >               used project id in build directory name
>> >               added 'INHERIT+='toaster buildhistory' to
>>conf/local.conf
>> >on toaster start
>> >Changes in v4: fixed builds on Ubuntu caused by dash being default
>>shell
>> >Changes in v5: fixed nasty bug in toasterui causing it to stuck in
>>event
>> >loop
>> >
>> >The following changes since commit
>> >01ab10ddaf21e34d8b3578975d1494cf0cfa4ef7:
>> >
>> >  toaster.bbclass: show packages that were setscened into existence too
>> >(2016-03-10 15:58:34 +0000)
>> >
>> >are available in the git repository at:
>> >
>> >  git://git.yoctoproject.org/poky-contrib
>> >ed/toaster/project-build-dir-7880
>> >  
>> 
>>>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/proj
>>>ec
>> >t-build-dir-7880
>> >
>> >Ed Bartosh (18):
>> >  toaster: don't start bitbake server
>> >  toaster: get rid of noui option
>> >  toaster: set BITBAKE_UI environment variable
>> >  toasterui: add brbe parameter to buildinfohelper
>> >  uievent: improve BBUIEventQueue code
>> >  buildinfohelper: improve handling of providermap
>> >  toasterui: fix brbe reporting
>> >  toaster: remove startBBServer API
>> >  toaster: remove release API
>> >  toaster: add brbe parameter to triggerBuild
>> >  toaster: modified setLayers API
>> >  toaster: reimplement triggerBuild
>> >  toaster: add new parameter to _shellcmd
>> >  toaster: stop bitbake server after the build
>> >  toaster: update conf/local.conf
>> >  toaster: fix jethro build
>> >  toaster: use bash explicitly
>> >  toasterui: shutdown on BuildCompleted event
>> >
>> >Elliot Smith (1):
>> >  toasterui: detect build run start correctly on Jethro
>> >
>> > bitbake/bin/toaster                                |  79 ++---------
>> > bitbake/lib/bb/ui/buildinfohelper.py               |  48 +++----
>> > bitbake/lib/bb/ui/toasterui.py                     |  48 ++++---
>> > bitbake/lib/bb/ui/uievent.py                       |  10 +-
>> > bitbake/lib/toaster/bldcontrol/bbcontroller.py     |  33 -----
>> > .../toaster/bldcontrol/localhostbecontroller.py    | 146
>> >++++++++++-----------
>> > .../bldcontrol/management/commands/runbuilds.py    |   6 +-
>> > 7 files changed, 147 insertions(+), 223 deletions(-)
>> >
>> >--
>> >Regards,
>> >Ed
>> >-- 
>> >_______________________________________________
>> >toaster mailing list
>> >toaster at yoctoproject.org
>> >https://lists.yoctoproject.org/listinfo/toaster
>> 
>
>-- 
>--
>Regards,
>Ed